FrankChen021 commented on code in PR #19908:
URL: https://github.com/apache/druid/pull/19908#discussion_r3731456425
##########
extensions-contrib/cloudfiles-extensions/src/test/java/org/apache/druid/storage/cloudfiles/CloudFilesObjectApiProxyTest.java:
##########
@@ -51,10 +51,10 @@ public void getTest()
CloudFilesObjectApiProxy cfoApiProxy = new
CloudFilesObjectApiProxy(cloudFilesApi, region, container);
CloudFilesObject cloudFilesObject = cfoApiProxy.get(path, 0);
- Assert.assertEquals(cloudFilesObject.getPayload(), payload);
- Assert.assertEquals(cloudFilesObject.getRegion(), region);
- Assert.assertEquals(cloudFilesObject.getContainer(), container);
- Assert.assertEquals(cloudFilesObject.getPath(), path);
+ Assertions.assertEquals(cloudFilesObject.getPayload(), payload);
+ Assertions.assertEquals(cloudFilesObject.getRegion(), region);
+ Assertions.assertEquals(cloudFilesObject.getContainer(), container);
+ Assertions.assertEquals(cloudFilesObject.getPath(), path);
Review Comment:
Fixed in commit `901605720b`: the CloudFiles object test now uses
`assertEquals(expected, actual)` for payload, region, container, and path so
failure diffs are meaningful. The focused CloudFiles tests passed (3 tests, 0
failures), and Checkstyle/SpotBugs passed.
##########
extensions-contrib/cloudfiles-extensions/src/test/java/org/apache/druid/storage/cloudfiles/CloudFilesByteSourceTest.java:
##########
@@ -78,10 +78,10 @@ public void openStreamWithRecoverableErrorTest() throws
IOException
byteSource.openStream();
}
catch (Exception e) {
- Assert.assertEquals("Recoverable exception", e.getMessage());
+ Assertions.assertEquals("Recoverable exception", e.getMessage());
}
- Assert.assertEquals(stream, byteSource.openStream());
+ Assertions.assertEquals(stream, byteSource.openStream());
Review Comment:
Fixed in commit `901605720b`: the first `openStream()` call now uses
`Assertions.assertThrows(IOException.class, byteSource::openStream)` and
asserts the recoverable-error message before retrying. The focused CloudFiles
tests passed (3 tests, 0 failures), and Checkstyle/SpotBugs passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
