capistrant commented on code in PR #19903:
URL: https://github.com/apache/druid/pull/19903#discussion_r3731487289
##########
server/src/main/java/org/apache/druid/server/coordinator/rules/ProjectionPartialLoadMatcher.java:
##########
@@ -47,17 +59,24 @@ public abstract class ProjectionPartialLoadMatcher
implements PartialLoadMatcher
/**
* Returns the sorted, deduped list of projection names from {@link
DataSegment#getProjections()} that this matcher
* selects. Returns an empty list when nothing matches (the segment exposes
no projections, or no configured pattern
- * intersects what the segment has).
+ * intersects what the segment has), which {@link #match} turns into a
base-table load rather than a non-match.
*/
protected abstract List<String> resolveProjectionNames(DataSegment segment);
+ /**
+ * Never returns {@code null}; see the class doc. Either the resolved
projections, or a base-table load when none of
+ * them are present on {@code segment}.
+ */
@Override
@Nullable
Review Comment:
nit: this impl is no longer `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
