FrankChen021 commented on PR #19910: URL: https://github.com/apache/druid/pull/19910#issuecomment-5209905065
Follow-up audit and cleanup pushed in commit `f0d72c8c23`. - Removed the unused test-scoped `com.github.stefanbirkner:system-rules` declaration from `indexing-service/pom.xml` only. - Audited `indexing-service` and `services`: no source imports or fully qualified references to `org.junit.contrib.java.lang.system`, other JUnit 4 APIs, or Hamcrest APIs remain; no stale direct JUnit 4, Vintage, JUnit migration-support, Hamcrest, or `system-rules` declarations remain in those module POMs. - Confirmed the root dependency-management entry and Java security-manager configuration were left unchanged because `server/pom.xml` still has the direct `system-rules` declaration. Shared root/server cleanup is deferred to a final dependency-cleanup PR after that ownership is removed. - Validation passed: `mvn test-compile -pl indexing-service,services -am -Pskip-static-checks -Dweb.console.skip=true -T1C` (including checkstyle and test compilation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
