FrankChen021 commented on PR #19909: URL: https://github.com/apache/druid/pull/19909#issuecomment-5210045795
Root cause: run 31129350780 failed because the SQL JUnit 5 migration removed the Hamcrest-returning exception API while unchanged MSQ tests still consumed it as `Matcher<Throwable>`. That dependency boundary caused the QTest shards plus validate-dist, static/packaging, and CodeQL failures. Fixed in `038fbef729` by integrating the validated MSQ migration from `adac0cc117` and `1869c51f68` under `multi-stage-query/**` only, removing MSQ's legacy JUnit/Hamcrest dependencies, and converting remaining MSQ exception assertions to Jupiter-backed helpers. The SQL schema temp-dir fixes are also present via `newTempFolder()`; the 24 focused SQL tests pass. MSQ Checkstyle and SpotBugs pass, and scoped audits find no JUnit 4/Hamcrest source imports or `.newFolder()`/`.newFile()` calls. The only local MSQ test-compile limitation is the separate shared indexing fixture's JUnit 4 `TaskActionTestKit` superclass, which is outside this PR's permitted paths and was not reintroduced as a compatibility dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
