FrankChen021 commented on PR #19911: URL: https://github.com/apache/druid/pull/19911#issuecomment-5210830880
CI follow-up for #13948 CI exposed that `CliPeonTest.makePeonInjectorWithStubEmitter` accepted the indexing-service `TempDirExtension`, leaking that test-only type to migrated consumers such as Kafka. This commit changes the helper to accept `java.io.File`, uses Jupiter `@TempDir File` in `CliPeonTest`, and writes the fixed `task.json` path under the supplied directory. No indexing-service, Kafka, SQL, MSQ, processing, or extensions files were changed; no JUnit4/Hamcrest compatibility was added. Validation: - `mvn -ntp -pl services -Dtest=org.apache.druid.cli.CliPeonTest -Dsurefire.failIfNoSpecifiedTests=false -Pskip-static-checks -Dweb.console.skip=true test`: 11 tests, 0 failures/errors. - Module `verify`: Checkstyle 0, PMD pass, forbidden-API compile/test checks 0, Enforcer pass. - SpotBugs: 0 bugs/errors. - Scoped source audit: no JUnit4/Hamcrest imports in services; the changed file is the only file in this commit. - The broader `-pl services -am` reactor is blocked by two unrelated existing SQL test compile errors where `temporaryFolder` is a `File` but calls `newFolder()`; SQL was intentionally out of scope. Commit: `64f2e3c0a5` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
