FrankChen021 commented on code in PR #19874: URL: https://github.com/apache/druid/pull/19874#discussion_r3732883974
########## AGENTS.md: ########## @@ -52,6 +52,8 @@ Real-time analytics database. Java, Maven, multi-module project. ## Running Tests +Use JUnit 5 (`org.junit.jupiter`) for new test cases; do not add new tests using JUnit 4 (`org.junit`). Review Comment: Addressed in commit `9ff5d01e29`. `AGENTS.md:55` now specifies JUnit 5 for new test classes and methods added to existing JUnit 5 classes; a method added to a JUnit 4 class requires migrating the class and its module first, otherwise the method remains JUnit 4 until migration. `git diff --check` passes, and the pushed PR head is `9ff5d01e29`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
