kfaraz opened a new pull request, #19921:
URL: https://github.com/apache/druid/pull/19921
### Description
This has been split from #19772 .
Instead of acquiring a lock for `markAsUsed` and `markAsUnused` APIs, this
patch tries to relax the locking requirements of a kill task but makes the
operation of `markAsUsed` and `markAsUnused` more strict.
### Changes
- Add new `TaskLockType.KILL`
- This lock can coexist with any other lock type but not with another `KILL`
lock to ensure that only a single `kill` task is working on a single
datasource-interval
- Always use new lock type for embedded kill tasks so that the
`UnusedSegmentsKiller` does not skip intervals with active ingestion.
- Do not allow a segment to be marked as used if it was last updated earlier
than the buffer period. This ensures that an unused segment that is now
eligible for kill is not accidentally marked as used while a `kill` task for
that segment is in progress.
### Pending changes
- Use a slightly higher buffer period for kill to further avoid any race
between the validation of `markAsUsed` API and the launch of a kill task (1-2
hours should be adequate, 1 day would be more than enough)
- Self review
- Tests
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
