github-advanced-security[bot] commented on code in PR #19920:
URL: https://github.com/apache/druid/pull/19920#discussion_r3737629412
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -87,13 +81,13 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertFalse(tuningConfig.isReportParseExceptions());
- Assert.assertEquals(IndexSpec.getDefault(), tuningConfig.getIndexSpec());
- Assert.assertEquals(new Period(Integer.MAX_VALUE),
tuningConfig.getIntermediatePersistPeriod());
- Assert.assertEquals(0, tuningConfig.getMaxPendingPersists());
- Assert.assertEquals(1000000, tuningConfig.getMaxRowsInMemory());
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertFalse(tuningConfig.isReportParseExceptions());
+ Assertions.assertEquals(IndexSpec.getDefault(),
tuningConfig.getIndexSpec());
+ Assertions.assertEquals(new Period(Integer.MAX_VALUE),
tuningConfig.getIntermediatePersistPeriod());
+ Assertions.assertEquals(0, tuningConfig.getMaxPendingPersists());
+ Assertions.assertEquals(1000000, tuningConfig.getMaxRowsInMemory());
+ Assertions.assertNull(tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11706)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -87,13 +81,13 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertFalse(tuningConfig.isReportParseExceptions());
- Assert.assertEquals(IndexSpec.getDefault(), tuningConfig.getIndexSpec());
- Assert.assertEquals(new Period(Integer.MAX_VALUE),
tuningConfig.getIntermediatePersistPeriod());
- Assert.assertEquals(0, tuningConfig.getMaxPendingPersists());
- Assert.assertEquals(1000000, tuningConfig.getMaxRowsInMemory());
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertFalse(tuningConfig.isReportParseExceptions());
+ Assertions.assertEquals(IndexSpec.getDefault(),
tuningConfig.getIndexSpec());
+ Assertions.assertEquals(new Period(Integer.MAX_VALUE),
tuningConfig.getIntermediatePersistPeriod());
+ Assertions.assertEquals(0, tuningConfig.getMaxPendingPersists());
+ Assertions.assertEquals(1000000, tuningConfig.getMaxRowsInMemory());
+ Assertions.assertNull(tuningConfig.getNumShards());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getNumShards](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11705)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11710)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"numShards\":10, \"forceGuaranteedRollup\":
true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":10,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11714)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"numShards\":10, \"forceGuaranteedRollup\":
true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":10,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":10, \"numShards\":-1}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":-1,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertNotNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(PartitionsSpec.DEFAULT_MAX_ROWS_PER_SEGMENT,
tuningConfig.getMaxRowsPerSegment().intValue());
+ Assertions.assertNull(tuningConfig.getNumShards());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getNumShards](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11718)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"numShards\":10, \"forceGuaranteedRollup\":
true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":10,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":10, \"numShards\":-1}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":-1,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertNotNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(PartitionsSpec.DEFAULT_MAX_ROWS_PER_SEGMENT,
tuningConfig.getMaxRowsPerSegment().intValue());
+ Assertions.assertNull(tuningConfig.getNumShards());
+ Assertions.assertNotNull(tuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11719)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -247,35 +252,35 @@
Thread.sleep(100); // Just want to run the clock a bit to make sure the
task id doesn't change
final IndexTask task2 = (IndexTask) jsonMapper.readValue(json, Task.class);
- Assert.assertEquals("foo", task.getDataSource());
+ Assertions.assertEquals("foo", task.getDataSource());
- Assert.assertEquals(task.getId(), task2.getId());
- Assert.assertEquals(task.getGroupId(), task2.getGroupId());
- Assert.assertEquals(task.getDataSource(), task2.getDataSource());
+ Assertions.assertEquals(task.getId(), task2.getId());
+ Assertions.assertEquals(task.getGroupId(), task2.getGroupId());
+ Assertions.assertEquals(task.getDataSource(), task2.getDataSource());
IndexTask.IndexIOConfig taskIoConfig =
task.getIngestionSchema().getIOConfig();
IndexTask.IndexIOConfig task2IoConfig =
task2.getIngestionSchema().getIOConfig();
- Assert.assertTrue(taskIoConfig.getInputSource() instanceof
LocalInputSource);
- Assert.assertTrue(task2IoConfig.getInputSource() instanceof
LocalInputSource);
- Assert.assertEquals(taskIoConfig.isAppendToExisting(),
task2IoConfig.isAppendToExisting());
- Assert.assertEquals(taskIoConfig.isDropExisting(),
task2IoConfig.isDropExisting());
+ Assertions.assertTrue(taskIoConfig.getInputSource() instanceof
LocalInputSource);
+ Assertions.assertTrue(task2IoConfig.getInputSource() instanceof
LocalInputSource);
+ Assertions.assertEquals(taskIoConfig.isAppendToExisting(),
task2IoConfig.isAppendToExisting());
+ Assertions.assertEquals(taskIoConfig.isDropExisting(),
task2IoConfig.isDropExisting());
IndexTask.IndexTuningConfig taskTuningConfig =
task.getIngestionSchema().getTuningConfig();
IndexTask.IndexTuningConfig task2TuningConfig =
task2.getIngestionSchema().getTuningConfig();
- Assert.assertEquals(taskTuningConfig.getBasePersistDirectory(),
task2TuningConfig.getBasePersistDirectory());
- Assert.assertEquals(taskTuningConfig.getIndexSpec(),
task2TuningConfig.getIndexSpec());
- Assert.assertEquals(
+ Assertions.assertEquals(taskTuningConfig.getBasePersistDirectory(),
task2TuningConfig.getBasePersistDirectory());
+ Assertions.assertEquals(taskTuningConfig.getIndexSpec(),
task2TuningConfig.getIndexSpec());
+ Assertions.assertEquals(
taskTuningConfig.getIntermediatePersistPeriod(),
task2TuningConfig.getIntermediatePersistPeriod()
);
- Assert.assertEquals(taskTuningConfig.getMaxPendingPersists(),
task2TuningConfig.getMaxPendingPersists());
- Assert.assertEquals(taskTuningConfig.getMaxRowsInMemory(),
task2TuningConfig.getMaxRowsInMemory());
- Assert.assertEquals(taskTuningConfig.getNumShards(),
task2TuningConfig.getNumShards());
- Assert.assertEquals(taskTuningConfig.getMaxRowsPerSegment(),
task2TuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(taskTuningConfig.isReportParseExceptions(),
task2TuningConfig.isReportParseExceptions());
-
Assert.assertEquals(taskTuningConfig.getAwaitSegmentAvailabilityTimeoutMillis(),
task2TuningConfig.getAwaitSegmentAvailabilityTimeoutMillis());
+ Assertions.assertEquals(taskTuningConfig.getMaxPendingPersists(),
task2TuningConfig.getMaxPendingPersists());
+ Assertions.assertEquals(taskTuningConfig.getMaxRowsInMemory(),
task2TuningConfig.getMaxRowsInMemory());
+ Assertions.assertEquals(taskTuningConfig.getNumShards(),
task2TuningConfig.getNumShards());
+ Assertions.assertEquals(taskTuningConfig.getMaxRowsPerSegment(),
task2TuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11724)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -247,35 +252,35 @@
Thread.sleep(100); // Just want to run the clock a bit to make sure the
task id doesn't change
final IndexTask task2 = (IndexTask) jsonMapper.readValue(json, Task.class);
- Assert.assertEquals("foo", task.getDataSource());
+ Assertions.assertEquals("foo", task.getDataSource());
- Assert.assertEquals(task.getId(), task2.getId());
- Assert.assertEquals(task.getGroupId(), task2.getGroupId());
- Assert.assertEquals(task.getDataSource(), task2.getDataSource());
+ Assertions.assertEquals(task.getId(), task2.getId());
+ Assertions.assertEquals(task.getGroupId(), task2.getGroupId());
+ Assertions.assertEquals(task.getDataSource(), task2.getDataSource());
IndexTask.IndexIOConfig taskIoConfig =
task.getIngestionSchema().getIOConfig();
IndexTask.IndexIOConfig task2IoConfig =
task2.getIngestionSchema().getIOConfig();
- Assert.assertTrue(taskIoConfig.getInputSource() instanceof
LocalInputSource);
- Assert.assertTrue(task2IoConfig.getInputSource() instanceof
LocalInputSource);
- Assert.assertEquals(taskIoConfig.isAppendToExisting(),
task2IoConfig.isAppendToExisting());
- Assert.assertEquals(taskIoConfig.isDropExisting(),
task2IoConfig.isDropExisting());
+ Assertions.assertTrue(taskIoConfig.getInputSource() instanceof
LocalInputSource);
+ Assertions.assertTrue(task2IoConfig.getInputSource() instanceof
LocalInputSource);
+ Assertions.assertEquals(taskIoConfig.isAppendToExisting(),
task2IoConfig.isAppendToExisting());
+ Assertions.assertEquals(taskIoConfig.isDropExisting(),
task2IoConfig.isDropExisting());
IndexTask.IndexTuningConfig taskTuningConfig =
task.getIngestionSchema().getTuningConfig();
IndexTask.IndexTuningConfig task2TuningConfig =
task2.getIngestionSchema().getTuningConfig();
- Assert.assertEquals(taskTuningConfig.getBasePersistDirectory(),
task2TuningConfig.getBasePersistDirectory());
- Assert.assertEquals(taskTuningConfig.getIndexSpec(),
task2TuningConfig.getIndexSpec());
- Assert.assertEquals(
+ Assertions.assertEquals(taskTuningConfig.getBasePersistDirectory(),
task2TuningConfig.getBasePersistDirectory());
+ Assertions.assertEquals(taskTuningConfig.getIndexSpec(),
task2TuningConfig.getIndexSpec());
+ Assertions.assertEquals(
taskTuningConfig.getIntermediatePersistPeriod(),
task2TuningConfig.getIntermediatePersistPeriod()
);
- Assert.assertEquals(taskTuningConfig.getMaxPendingPersists(),
task2TuningConfig.getMaxPendingPersists());
- Assert.assertEquals(taskTuningConfig.getMaxRowsInMemory(),
task2TuningConfig.getMaxRowsInMemory());
- Assert.assertEquals(taskTuningConfig.getNumShards(),
task2TuningConfig.getNumShards());
- Assert.assertEquals(taskTuningConfig.getMaxRowsPerSegment(),
task2TuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(taskTuningConfig.isReportParseExceptions(),
task2TuningConfig.isReportParseExceptions());
-
Assert.assertEquals(taskTuningConfig.getAwaitSegmentAvailabilityTimeoutMillis(),
task2TuningConfig.getAwaitSegmentAvailabilityTimeoutMillis());
+ Assertions.assertEquals(taskTuningConfig.getMaxPendingPersists(),
task2TuningConfig.getMaxPendingPersists());
+ Assertions.assertEquals(taskTuningConfig.getMaxRowsInMemory(),
task2TuningConfig.getMaxRowsInMemory());
+ Assertions.assertEquals(taskTuningConfig.getNumShards(),
task2TuningConfig.getNumShards());
+ Assertions.assertEquals(taskTuningConfig.getMaxRowsPerSegment(),
task2TuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11723)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11707)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"numShards\":10, \"forceGuaranteedRollup\":
true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11712)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11709)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getNumShards](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11708)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"numShards\":10, \"forceGuaranteedRollup\":
true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getNumShards](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11713)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"numShards\":10, \"forceGuaranteedRollup\":
true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":10,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":10, \"numShards\":-1}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":-1,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertNotNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(PartitionsSpec.DEFAULT_MAX_ROWS_PER_SEGMENT,
tuningConfig.getMaxRowsPerSegment().intValue());
+ Assertions.assertNull(tuningConfig.getNumShards());
+ Assertions.assertNotNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(PartitionsSpec.DEFAULT_MAX_ROWS_PER_SEGMENT,
tuningConfig.getMaxRowsPerSegment().intValue());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11720)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -247,35 +252,35 @@
Thread.sleep(100); // Just want to run the clock a bit to make sure the
task id doesn't change
final IndexTask task2 = (IndexTask) jsonMapper.readValue(json, Task.class);
- Assert.assertEquals("foo", task.getDataSource());
+ Assertions.assertEquals("foo", task.getDataSource());
- Assert.assertEquals(task.getId(), task2.getId());
- Assert.assertEquals(task.getGroupId(), task2.getGroupId());
- Assert.assertEquals(task.getDataSource(), task2.getDataSource());
+ Assertions.assertEquals(task.getId(), task2.getId());
+ Assertions.assertEquals(task.getGroupId(), task2.getGroupId());
+ Assertions.assertEquals(task.getDataSource(), task2.getDataSource());
IndexTask.IndexIOConfig taskIoConfig =
task.getIngestionSchema().getIOConfig();
IndexTask.IndexIOConfig task2IoConfig =
task2.getIngestionSchema().getIOConfig();
- Assert.assertTrue(taskIoConfig.getInputSource() instanceof
LocalInputSource);
- Assert.assertTrue(task2IoConfig.getInputSource() instanceof
LocalInputSource);
- Assert.assertEquals(taskIoConfig.isAppendToExisting(),
task2IoConfig.isAppendToExisting());
- Assert.assertEquals(taskIoConfig.isDropExisting(),
task2IoConfig.isDropExisting());
+ Assertions.assertTrue(taskIoConfig.getInputSource() instanceof
LocalInputSource);
+ Assertions.assertTrue(task2IoConfig.getInputSource() instanceof
LocalInputSource);
+ Assertions.assertEquals(taskIoConfig.isAppendToExisting(),
task2IoConfig.isAppendToExisting());
+ Assertions.assertEquals(taskIoConfig.isDropExisting(),
task2IoConfig.isDropExisting());
IndexTask.IndexTuningConfig taskTuningConfig =
task.getIngestionSchema().getTuningConfig();
IndexTask.IndexTuningConfig task2TuningConfig =
task2.getIngestionSchema().getTuningConfig();
- Assert.assertEquals(taskTuningConfig.getBasePersistDirectory(),
task2TuningConfig.getBasePersistDirectory());
- Assert.assertEquals(taskTuningConfig.getIndexSpec(),
task2TuningConfig.getIndexSpec());
- Assert.assertEquals(
+ Assertions.assertEquals(taskTuningConfig.getBasePersistDirectory(),
task2TuningConfig.getBasePersistDirectory());
+ Assertions.assertEquals(taskTuningConfig.getIndexSpec(),
task2TuningConfig.getIndexSpec());
+ Assertions.assertEquals(
taskTuningConfig.getIntermediatePersistPeriod(),
task2TuningConfig.getIntermediatePersistPeriod()
);
- Assert.assertEquals(taskTuningConfig.getMaxPendingPersists(),
task2TuningConfig.getMaxPendingPersists());
- Assert.assertEquals(taskTuningConfig.getMaxRowsInMemory(),
task2TuningConfig.getMaxRowsInMemory());
- Assert.assertEquals(taskTuningConfig.getNumShards(),
task2TuningConfig.getNumShards());
- Assert.assertEquals(taskTuningConfig.getMaxRowsPerSegment(),
task2TuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(taskTuningConfig.isReportParseExceptions(),
task2TuningConfig.isReportParseExceptions());
-
Assert.assertEquals(taskTuningConfig.getAwaitSegmentAvailabilityTimeoutMillis(),
task2TuningConfig.getAwaitSegmentAvailabilityTimeoutMillis());
+ Assertions.assertEquals(taskTuningConfig.getMaxPendingPersists(),
task2TuningConfig.getMaxPendingPersists());
+ Assertions.assertEquals(taskTuningConfig.getMaxRowsInMemory(),
task2TuningConfig.getMaxRowsInMemory());
+ Assertions.assertEquals(taskTuningConfig.getNumShards(),
task2TuningConfig.getNumShards());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getNumShards](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11721)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getNumShards](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11711)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"numShards\":10, \"forceGuaranteedRollup\":
true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":10,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getNumShards](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11715)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"numShards\":10, \"forceGuaranteedRollup\":
true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":10,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":10, \"numShards\":-1}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getNumShards](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11716)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -104,67 +98,69 @@
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\"}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"maxRowsPerSegment\":10}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
- Assert.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"numShards\":10, \"forceGuaranteedRollup\":
true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":-1, \"numShards\":10,
\"forceGuaranteedRollup\": true}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(10, (int) tuningConfig.getNumShards());
+ Assertions.assertNull(tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertEquals(10, (int) tuningConfig.getNumShards());
tuningConfig = jsonMapper.readValue(
"{\"type\":\"index\", \"targetPartitionSize\":10, \"numShards\":-1}",
IndexTask.IndexTuningConfig.class
);
- Assert.assertNull(tuningConfig.getNumShards());
- Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
+ Assertions.assertNull(tuningConfig.getNumShards());
+ Assertions.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getMaxRowsPerSegment](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11717)
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java:
##########
@@ -247,35 +252,35 @@
Thread.sleep(100); // Just want to run the clock a bit to make sure the
task id doesn't change
final IndexTask task2 = (IndexTask) jsonMapper.readValue(json, Task.class);
- Assert.assertEquals("foo", task.getDataSource());
+ Assertions.assertEquals("foo", task.getDataSource());
- Assert.assertEquals(task.getId(), task2.getId());
- Assert.assertEquals(task.getGroupId(), task2.getGroupId());
- Assert.assertEquals(task.getDataSource(), task2.getDataSource());
+ Assertions.assertEquals(task.getId(), task2.getId());
+ Assertions.assertEquals(task.getGroupId(), task2.getGroupId());
+ Assertions.assertEquals(task.getDataSource(), task2.getDataSource());
IndexTask.IndexIOConfig taskIoConfig =
task.getIngestionSchema().getIOConfig();
IndexTask.IndexIOConfig task2IoConfig =
task2.getIngestionSchema().getIOConfig();
- Assert.assertTrue(taskIoConfig.getInputSource() instanceof
LocalInputSource);
- Assert.assertTrue(task2IoConfig.getInputSource() instanceof
LocalInputSource);
- Assert.assertEquals(taskIoConfig.isAppendToExisting(),
task2IoConfig.isAppendToExisting());
- Assert.assertEquals(taskIoConfig.isDropExisting(),
task2IoConfig.isDropExisting());
+ Assertions.assertTrue(taskIoConfig.getInputSource() instanceof
LocalInputSource);
+ Assertions.assertTrue(task2IoConfig.getInputSource() instanceof
LocalInputSource);
+ Assertions.assertEquals(taskIoConfig.isAppendToExisting(),
task2IoConfig.isAppendToExisting());
+ Assertions.assertEquals(taskIoConfig.isDropExisting(),
task2IoConfig.isDropExisting());
IndexTask.IndexTuningConfig taskTuningConfig =
task.getIngestionSchema().getTuningConfig();
IndexTask.IndexTuningConfig task2TuningConfig =
task2.getIngestionSchema().getTuningConfig();
- Assert.assertEquals(taskTuningConfig.getBasePersistDirectory(),
task2TuningConfig.getBasePersistDirectory());
- Assert.assertEquals(taskTuningConfig.getIndexSpec(),
task2TuningConfig.getIndexSpec());
- Assert.assertEquals(
+ Assertions.assertEquals(taskTuningConfig.getBasePersistDirectory(),
task2TuningConfig.getBasePersistDirectory());
+ Assertions.assertEquals(taskTuningConfig.getIndexSpec(),
task2TuningConfig.getIndexSpec());
+ Assertions.assertEquals(
taskTuningConfig.getIntermediatePersistPeriod(),
task2TuningConfig.getIntermediatePersistPeriod()
);
- Assert.assertEquals(taskTuningConfig.getMaxPendingPersists(),
task2TuningConfig.getMaxPendingPersists());
- Assert.assertEquals(taskTuningConfig.getMaxRowsInMemory(),
task2TuningConfig.getMaxRowsInMemory());
- Assert.assertEquals(taskTuningConfig.getNumShards(),
task2TuningConfig.getNumShards());
- Assert.assertEquals(taskTuningConfig.getMaxRowsPerSegment(),
task2TuningConfig.getMaxRowsPerSegment());
- Assert.assertEquals(taskTuningConfig.isReportParseExceptions(),
task2TuningConfig.isReportParseExceptions());
-
Assert.assertEquals(taskTuningConfig.getAwaitSegmentAvailabilityTimeoutMillis(),
task2TuningConfig.getAwaitSegmentAvailabilityTimeoutMillis());
+ Assertions.assertEquals(taskTuningConfig.getMaxPendingPersists(),
task2TuningConfig.getMaxPendingPersists());
+ Assertions.assertEquals(taskTuningConfig.getMaxRowsInMemory(),
task2TuningConfig.getMaxRowsInMemory());
+ Assertions.assertEquals(taskTuningConfig.getNumShards(),
task2TuningConfig.getNumShards());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [IndexTuningConfig.getNumShards](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11722)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
