FrankChen021 commented on code in PR #19925:
URL: https://github.com/apache/druid/pull/19925#discussion_r3739914081
##########
indexing-service/src/test/java/org/apache/druid/indexing/worker/WorkerTaskManagerTest.java:
##########
@@ -91,22 +95,21 @@ public class WorkerTaskManagerTest
private final IndexMergerV9Factory indexMergerV9Factory;
private final IndexIO indexIO;
- private final boolean restoreTasksOnRestart;
+ @Parameter(0)
+ private boolean restoreTasksOnRestart;
Review Comment:
Addressed in the existing local edit: changed restoreTasksOnRestart from
private to public so JUnit 5 ParameterizedClass can inject it consistently.
##########
indexing-service/src/test/java/org/apache/druid/indexing/worker/shuffle/ShuffleDataSegmentPusherTest.java:
##########
@@ -68,45 +67,41 @@
import java.util.List;
import java.util.Optional;
-@RunWith(Parameterized.class)
+@ParameterizedClass
+@MethodSource("data")
public class ShuffleDataSegmentPusherTest
{
private static final String LOCAL = "local";
private static final String DEEPSTORE = "deepstore";
- @Parameterized.Parameters(name = "intermediateDataManager={0}")
public static Collection<Object[]> data()
{
return ImmutableList.of(new Object[]{LOCAL}, new Object[]{DEEPSTORE});
}
- @Rule
- public final TemporaryFolder temporaryFolder = new TemporaryFolder();
+ @Parameter(0)
+ private String intermediateDataStore;
+
Review Comment:
Addressed in the existing local edit: changed intermediateDataStore from
private to public to match the established ParameterizedClass injection pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
