FrankChen021 commented on code in PR #19915:
URL: https://github.com/apache/druid/pull/19915#discussion_r3740241685
##########
extensions-contrib/moving-average-query/src/test/java/org/apache/druid/query/movingaverage/MovingAverageQueryTest.java:
##########
@@ -102,9 +101,17 @@
/**
* Base class for implementing MovingAverageQuery tests
*/
-@RunWith(Parameterized.class)
+@ParameterizedClass(name = "{0}")
+@MethodSource("data")
public class MovingAverageQueryTest extends InitializedNullHandlingTest
{
+ private static final QueryScheduler NOOP_SCHEDULER = new QueryScheduler(
Review Comment:
It's OK to define a new scheduler here intead of depending on the one in
other modules. This also eliminates the extra dependencies across test modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
