github-advanced-security[bot] commented on code in PR #19939:
URL: https://github.com/apache/druid/pull/19939#discussion_r3742296526
##########
sql/src/test/java/org/apache/druid/sql/calcite/schema/BrokerSegmentMetadataCacheTest.java:
##########
@@ -689,10 +689,10 @@
.findFirst()
.orElse(null);
final AvailableSegmentMetadata currentMetadata =
segmentsMetadata.get(currentSegment.getId());
- Assert.assertEquals(updatedMetadata.getSegment().getId(),
currentMetadata.getSegment().getId());
- Assert.assertEquals(updatedMetadata.getNumRows(),
currentMetadata.getNumRows());
+ Assertions.assertEquals(updatedMetadata.getSegment().getId(),
currentMetadata.getSegment().getId());
+ Assertions.assertEquals(updatedMetadata.getNumRows(),
currentMetadata.getNumRows());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [AvailableSegmentMetadata.getNumRows](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11755)
##########
sql/src/test/java/org/apache/druid/sql/calcite/schema/BrokerSegmentMetadataCacheTest.java:
##########
@@ -689,10 +689,10 @@
.findFirst()
.orElse(null);
final AvailableSegmentMetadata currentMetadata =
segmentsMetadata.get(currentSegment.getId());
- Assert.assertEquals(updatedMetadata.getSegment().getId(),
currentMetadata.getSegment().getId());
- Assert.assertEquals(updatedMetadata.getNumRows(),
currentMetadata.getNumRows());
+ Assertions.assertEquals(updatedMetadata.getSegment().getId(),
currentMetadata.getSegment().getId());
+ Assertions.assertEquals(updatedMetadata.getNumRows(),
currentMetadata.getNumRows());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [AvailableSegmentMetadata.getNumRows](1) should be avoided because
it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11754)
##########
sql/src/test/java/org/apache/druid/sql/calcite/schema/BrokerSegmentMetadataCacheTestBase.java:
##########
@@ -97,4 +110,10 @@
serverView = new TestTimelineServerView(walker.getSegments(),
realtimeSegments);
druidServers = serverView.getDruidServers();
}
+
+ public void tearDown() throws Exception
Review Comment:
## CodeQL / Missing Override annotation
This method overrides [SegmentMetadataCacheTestBase.tearDown](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11753)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
