FrankChen021 commented on PR #19940: URL: https://github.com/apache/druid/pull/19940#issuecomment-5229866211
Addressed the five CodeQL review findings from this run: - StringUtilsTest.java:159 — evaluated as pre-existing and intentional coverage of nonStrictFormat behavior; the migration only changed the assertion API, so no code change was made. - CompressionUtilsTest.java:647 — the arithmetic expression predates this PR; only the assertion API changed, so it was left unchanged. - CloseableUtilsTest.java:83 and :112 — the nullable local is intentional exception-capture test setup and predates this PR; left unchanged. - LoggerCaptureExtension.java:94 — valid and introduced by this PR. Fixed in commit 3b92250d3c by using the supported AbstractAppender constructor with Property.EMPTY_ARRAY. Processing test compilation passed. Inline replies are not permitted for this account on the upstream repository, so this comment records the response for each thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
