github-advanced-security[bot] commented on code in PR #19980:
URL: https://github.com/apache/druid/pull/19980#discussion_r3763930863
##########
processing/src/test/java/org/apache/druid/query/timeseries/TimeseriesQueryRunnerTest.java:
##########
@@ -324,7 +324,7 @@
}
stubServiceEmitter.verifyEmitted("query/wait/time",
ImmutableMap.of("vectorized", vectorize), 1);
- Assert.assertEquals(lastResult.toString(), expectedLast,
lastResult.getTimestamp());
+ JupiterAssertions.assertEquals(lastResult.toString(), expectedLast,
lastResult.getTimestamp());
Review Comment:
## CodeQL / Dereferenced variable may be null
Variable [lastResult](1) may be null at this access because of [this](2)
assignment.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11796)
##########
processing/src/test/java/org/apache/druid/query/metadata/SegmentAnalyzerTest.java:
##########
@@ -331,9 +332,9 @@
IncrementalIndexSegment segment = new
IncrementalIndexSegment(incrementalIndex, SegmentId.dummy("ds"));
Map<String, ColumnAnalysis> analyses = analyzer.analyze(segment);
ColumnAnalysis columnAnalysis = analyses.get(invalid_aggregator);
- Assert.assertFalse(columnAnalysis.isError());
- Assert.assertEquals("invalid_complex_column_type",
columnAnalysis.getType());
- Assert.assertEquals(ColumnType.ofComplex("invalid_complex_column_type"),
columnAnalysis.getTypeSignature());
+ JupiterAssertions.assertFalse(columnAnalysis.isError());
+ JupiterAssertions.assertEquals("invalid_complex_column_type",
columnAnalysis.getType());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [ColumnAnalysis.getType](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11806)
##########
processing/src/test/java/org/apache/druid/query/timeseries/TimeseriesQueryRunnerTest.java:
##########
@@ -2925,7 +2925,7 @@
++count;
}
- Assert.assertEquals(lastResult.toString(), expectedLast,
lastResult.getTimestamp());
+ JupiterAssertions.assertEquals(lastResult.toString(), expectedLast,
lastResult.getTimestamp());
Review Comment:
## CodeQL / Dereferenced variable may be null
Variable [lastResult](1) may be null at this access because of [this](2)
assignment.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11799)
##########
processing/src/test/java/org/apache/druid/query/timeseries/TimeseriesQueryRunnerTest.java:
##########
@@ -348,15 +348,15 @@
Result lastResult = null;
for (Result<TimeseriesResultValue> result : results) {
DateTime current = result.getTimestamp();
- Assert.assertFalse(
+ JupiterAssertions.assertFalse(
StringUtils.format("Timestamp[%s] > expectedLast[%s]", current,
expectedLast),
descending ? current.isBefore(expectedLast) :
current.isAfter(expectedLast)
);
- Assert.assertEquals(ImmutableMap.of(),
result.getValue().getBaseObject());
+ JupiterAssertions.assertEquals(ImmutableMap.of(),
result.getValue().getBaseObject());
lastResult = result;
}
- Assert.assertEquals(lastResult.toString(), expectedLast,
lastResult.getTimestamp());
+ JupiterAssertions.assertEquals(lastResult.toString(), expectedLast,
lastResult.getTimestamp());
Review Comment:
## CodeQL / Dereferenced variable may be null
Variable [lastResult](1) may be null at this access because of [this](2)
assignment.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11797)
##########
processing/src/test/java/org/apache/druid/query/timeseries/TimeseriesQueryRunnerTest.java:
##########
@@ -2771,56 +2771,56 @@
Object[] lastResult = null;
for (Object[] result : resultsAsArrays.toList()) {
Long current = (Long) result[0];
- Assert.assertFalse(
+ JupiterAssertions.assertFalse(
StringUtils.format("Timestamp[%s] > expectedLast[%s]", current,
expectedLast),
descending ? current < expectedLast : current > expectedLast
);
- Assert.assertEquals(
+ JupiterAssertions.assertEquals(
(Long) result[1],
current,
0
);
- Assert.assertEquals(
+ JupiterAssertions.assertEquals(
QueryRunnerTestHelper.SKIPPED_DAY.getMillis() == current ? (Long) 0L
: (Long) 13L,
result[2]
);
if (QueryRunnerTestHelper.SKIPPED_DAY.getMillis() != current) {
- Assert.assertEquals(
+ JupiterAssertions.assertEquals(
Double.parseDouble(expectedIndexToUse[count]),
(Double) result[3],
(Double) result[3] * 1e-6
);
- Assert.assertEquals(
+ JupiterAssertions.assertEquals(
9.0d,
(Double) result[4],
0.02
);
- Assert.assertEquals(
+ JupiterAssertions.assertEquals(
Double.parseDouble(expectedIndexToUse[count]) + 13L + 1L,
(Double) result[5],
(Double) result[5] * 1e-6
);
} else {
- Assert.assertNull(
+ JupiterAssertions.assertNull(
result[3]
);
- Assert.assertEquals(
+ JupiterAssertions.assertEquals(
0.0,
(Double) result[4],
0.02
);
- Assert.assertNull(
+ JupiterAssertions.assertNull(
result[5]
);
}
lastResult = result;
++count;
}
- Assert.assertEquals(expectedLast, lastResult[0]);
+ JupiterAssertions.assertEquals(expectedLast, lastResult[0]);
Review Comment:
## CodeQL / Dereferenced variable may be null
Variable [lastResult](1) may be null at this access because of [this](2)
assignment.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11798)
##########
processing/src/test/java/org/apache/druid/query/scan/ScanQueryTest.java:
##########
@@ -117,13 +117,14 @@
.dataSource("source")
.intervals(intervalSpec)
.build();
- Assert.assertFalse(query.isLegacy());
+ JupiterAssertions.assertFalse(query.isLegacy());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [ScanQuery.isLegacy](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11807)
##########
processing/src/test/java/org/apache/druid/query/metadata/SegmentAnalyzerTest.java:
##########
@@ -182,54 +183,54 @@
analyses
);
- Assert.assertEquals(1, results.size());
+ JupiterAssertions.assertEquals(1, results.size());
final SegmentAnalysis analysis = results.get(0);
- Assert.assertEquals(SegmentId.dummy("test_1").toString(),
analysis.getId());
+ JupiterAssertions.assertEquals(SegmentId.dummy("test_1").toString(),
analysis.getId());
final Map<String, ColumnAnalysis> columns = analysis.getColumns();
// Verify key order is the same as the underlying segment.
// This helps DruidSchema keep things in the proper order when it does
SegmentMetadata queries.
final List<Map.Entry<String, ColumnAnalysis>> entriesInOrder = new
ArrayList<>(columns.entrySet());
- Assert.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
- Assert.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
+ JupiterAssertions.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
+ JupiterAssertions.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
// Start from 1: skipping __time
for (int i = 0; i < TestIndex.DIMENSION_SCHEMAS.size(); i++) {
final DimensionSchema schema = TestIndex.DIMENSION_SCHEMAS.get(i);
final Map.Entry<String, ColumnAnalysis> analysisEntry =
entriesInOrder.get(i + 1 /* skip __time */);
final String dimension = schema.getName();
- Assert.assertEquals(dimension, analysisEntry.getKey());
+ JupiterAssertions.assertEquals(dimension, analysisEntry.getKey());
final ColumnAnalysis columnAnalysis = analysisEntry.getValue();
final boolean isString = schema.getColumnType().is(ValueType.STRING);
- Assert.assertEquals(dimension, schema.getColumnType().toString(),
columnAnalysis.getType());
- Assert.assertEquals(dimension, 0, columnAnalysis.getSize());
+ JupiterAssertions.assertEquals(dimension,
schema.getColumnType().toString(), columnAnalysis.getType());
+ JupiterAssertions.assertEquals(dimension, 0, columnAnalysis.getSize());
if (isString) {
if (analyses == null) {
- Assert.assertTrue(dimension, columnAnalysis.getCardinality() > 0);
+ JupiterAssertions.assertTrue(dimension,
columnAnalysis.getCardinality() > 0);
} else {
- Assert.assertEquals(dimension, 0,
columnAnalysis.getCardinality().longValue());
+ JupiterAssertions.assertEquals(dimension, 0,
columnAnalysis.getCardinality().longValue());
}
} else {
- Assert.assertNull(dimension, columnAnalysis.getCardinality());
+ JupiterAssertions.assertNull(dimension,
columnAnalysis.getCardinality());
}
}
for (String metric : TestIndex.DOUBLE_METRICS) {
final ColumnAnalysis columnAnalysis = columns.get(metric);
- Assert.assertEquals(metric, ValueType.DOUBLE.name(),
columnAnalysis.getType());
- Assert.assertEquals(metric, 0, columnAnalysis.getSize());
- Assert.assertNull(metric, columnAnalysis.getCardinality());
+ JupiterAssertions.assertEquals(metric, ValueType.DOUBLE.name(),
columnAnalysis.getType());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [ColumnAnalysis.getType](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11804)
##########
processing/src/test/java/org/apache/druid/query/metadata/SegmentAnalyzerTest.java:
##########
@@ -182,54 +183,54 @@
analyses
);
- Assert.assertEquals(1, results.size());
+ JupiterAssertions.assertEquals(1, results.size());
final SegmentAnalysis analysis = results.get(0);
- Assert.assertEquals(SegmentId.dummy("test_1").toString(),
analysis.getId());
+ JupiterAssertions.assertEquals(SegmentId.dummy("test_1").toString(),
analysis.getId());
final Map<String, ColumnAnalysis> columns = analysis.getColumns();
// Verify key order is the same as the underlying segment.
// This helps DruidSchema keep things in the proper order when it does
SegmentMetadata queries.
final List<Map.Entry<String, ColumnAnalysis>> entriesInOrder = new
ArrayList<>(columns.entrySet());
- Assert.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
- Assert.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
+ JupiterAssertions.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
+ JupiterAssertions.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
// Start from 1: skipping __time
for (int i = 0; i < TestIndex.DIMENSION_SCHEMAS.size(); i++) {
final DimensionSchema schema = TestIndex.DIMENSION_SCHEMAS.get(i);
final Map.Entry<String, ColumnAnalysis> analysisEntry =
entriesInOrder.get(i + 1 /* skip __time */);
final String dimension = schema.getName();
- Assert.assertEquals(dimension, analysisEntry.getKey());
+ JupiterAssertions.assertEquals(dimension, analysisEntry.getKey());
final ColumnAnalysis columnAnalysis = analysisEntry.getValue();
final boolean isString = schema.getColumnType().is(ValueType.STRING);
- Assert.assertEquals(dimension, schema.getColumnType().toString(),
columnAnalysis.getType());
- Assert.assertEquals(dimension, 0, columnAnalysis.getSize());
+ JupiterAssertions.assertEquals(dimension,
schema.getColumnType().toString(), columnAnalysis.getType());
+ JupiterAssertions.assertEquals(dimension, 0, columnAnalysis.getSize());
if (isString) {
if (analyses == null) {
- Assert.assertTrue(dimension, columnAnalysis.getCardinality() > 0);
+ JupiterAssertions.assertTrue(dimension,
columnAnalysis.getCardinality() > 0);
} else {
- Assert.assertEquals(dimension, 0,
columnAnalysis.getCardinality().longValue());
+ JupiterAssertions.assertEquals(dimension, 0,
columnAnalysis.getCardinality().longValue());
}
} else {
- Assert.assertNull(dimension, columnAnalysis.getCardinality());
+ JupiterAssertions.assertNull(dimension,
columnAnalysis.getCardinality());
}
}
for (String metric : TestIndex.DOUBLE_METRICS) {
final ColumnAnalysis columnAnalysis = columns.get(metric);
- Assert.assertEquals(metric, ValueType.DOUBLE.name(),
columnAnalysis.getType());
- Assert.assertEquals(metric, 0, columnAnalysis.getSize());
- Assert.assertNull(metric, columnAnalysis.getCardinality());
+ JupiterAssertions.assertEquals(metric, ValueType.DOUBLE.name(),
columnAnalysis.getType());
+ JupiterAssertions.assertEquals(metric, 0, columnAnalysis.getSize());
+ JupiterAssertions.assertNull(metric, columnAnalysis.getCardinality());
}
for (String metric : TestIndex.FLOAT_METRICS) {
final ColumnAnalysis columnAnalysis = columns.get(metric);
- Assert.assertEquals(metric, ValueType.FLOAT.name(),
columnAnalysis.getType());
- Assert.assertEquals(metric, 0, columnAnalysis.getSize());
- Assert.assertNull(metric, columnAnalysis.getCardinality());
+ JupiterAssertions.assertEquals(metric, ValueType.FLOAT.name(),
columnAnalysis.getType());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [ColumnAnalysis.getType](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11805)
##########
processing/src/test/java/org/apache/druid/query/metadata/SegmentAnalyzerTest.java:
##########
@@ -128,43 +129,43 @@
// This helps DruidSchema keep things in the proper order when it does
SegmentMetadata queries.
final List<Map.Entry<String, ColumnAnalysis>> entriesInOrder = new
ArrayList<>(columns.entrySet());
- Assert.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
- Assert.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
+ JupiterAssertions.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
+ JupiterAssertions.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
// Start from 1: skipping __time
for (int i = 0; i < TestIndex.DIMENSION_SCHEMAS.size(); i++) {
final DimensionSchema schema = TestIndex.DIMENSION_SCHEMAS.get(i);
final Map.Entry<String, ColumnAnalysis> analysisEntry =
entriesInOrder.get(i + 1 /* skip __time */);
final String dimension = schema.getName();
- Assert.assertEquals(dimension, analysisEntry.getKey());
+ JupiterAssertions.assertEquals(dimension, analysisEntry.getKey());
final ColumnAnalysis columnAnalysis = analysisEntry.getValue();
final boolean isString = schema.getColumnType().is(ValueType.STRING);
- Assert.assertEquals(dimension, schema.getColumnType().toString(),
columnAnalysis.getType());
- Assert.assertEquals(dimension, 0, columnAnalysis.getSize());
+ JupiterAssertions.assertEquals(dimension,
schema.getColumnType().toString(), columnAnalysis.getType());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [ColumnAnalysis.getType](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11800)
##########
processing/src/test/java/org/apache/druid/query/metadata/SegmentAnalyzerTest.java:
##########
@@ -128,43 +129,43 @@
// This helps DruidSchema keep things in the proper order when it does
SegmentMetadata queries.
final List<Map.Entry<String, ColumnAnalysis>> entriesInOrder = new
ArrayList<>(columns.entrySet());
- Assert.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
- Assert.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
+ JupiterAssertions.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
+ JupiterAssertions.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
// Start from 1: skipping __time
for (int i = 0; i < TestIndex.DIMENSION_SCHEMAS.size(); i++) {
final DimensionSchema schema = TestIndex.DIMENSION_SCHEMAS.get(i);
final Map.Entry<String, ColumnAnalysis> analysisEntry =
entriesInOrder.get(i + 1 /* skip __time */);
final String dimension = schema.getName();
- Assert.assertEquals(dimension, analysisEntry.getKey());
+ JupiterAssertions.assertEquals(dimension, analysisEntry.getKey());
final ColumnAnalysis columnAnalysis = analysisEntry.getValue();
final boolean isString = schema.getColumnType().is(ValueType.STRING);
- Assert.assertEquals(dimension, schema.getColumnType().toString(),
columnAnalysis.getType());
- Assert.assertEquals(dimension, 0, columnAnalysis.getSize());
+ JupiterAssertions.assertEquals(dimension,
schema.getColumnType().toString(), columnAnalysis.getType());
+ JupiterAssertions.assertEquals(dimension, 0, columnAnalysis.getSize());
if (isString) {
if (analyses == null) {
- Assert.assertTrue(dimension, columnAnalysis.getCardinality() > 0);
+ JupiterAssertions.assertTrue(dimension,
columnAnalysis.getCardinality() > 0);
} else {
- Assert.assertEquals(dimension, 0,
columnAnalysis.getCardinality().longValue());
+ JupiterAssertions.assertEquals(dimension, 0,
columnAnalysis.getCardinality().longValue());
}
} else {
- Assert.assertNull(dimension, columnAnalysis.getCardinality());
+ JupiterAssertions.assertNull(dimension,
columnAnalysis.getCardinality());
}
}
for (String metric : TestIndex.DOUBLE_METRICS) {
final ColumnAnalysis columnAnalysis = columns.get(metric);
- Assert.assertEquals(metric, ValueType.DOUBLE.name(),
columnAnalysis.getType());
- Assert.assertEquals(metric, 0, columnAnalysis.getSize());
- Assert.assertNull(metric, columnAnalysis.getCardinality());
+ JupiterAssertions.assertEquals(metric, ValueType.DOUBLE.name(),
columnAnalysis.getType());
+ JupiterAssertions.assertEquals(metric, 0, columnAnalysis.getSize());
+ JupiterAssertions.assertNull(metric, columnAnalysis.getCardinality());
}
for (String metric : TestIndex.FLOAT_METRICS) {
final ColumnAnalysis columnAnalysis = columns.get(metric);
- Assert.assertEquals(metric, ValueType.FLOAT.name(),
columnAnalysis.getType());
- Assert.assertEquals(metric, 0, columnAnalysis.getSize());
- Assert.assertNull(metric, columnAnalysis.getCardinality());
+ JupiterAssertions.assertEquals(metric, ValueType.FLOAT.name(),
columnAnalysis.getType());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [ColumnAnalysis.getType](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11802)
##########
processing/src/test/java/org/apache/druid/query/metadata/SegmentAnalyzerTest.java:
##########
@@ -128,43 +129,43 @@
// This helps DruidSchema keep things in the proper order when it does
SegmentMetadata queries.
final List<Map.Entry<String, ColumnAnalysis>> entriesInOrder = new
ArrayList<>(columns.entrySet());
- Assert.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
- Assert.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
+ JupiterAssertions.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
+ JupiterAssertions.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
// Start from 1: skipping __time
for (int i = 0; i < TestIndex.DIMENSION_SCHEMAS.size(); i++) {
final DimensionSchema schema = TestIndex.DIMENSION_SCHEMAS.get(i);
final Map.Entry<String, ColumnAnalysis> analysisEntry =
entriesInOrder.get(i + 1 /* skip __time */);
final String dimension = schema.getName();
- Assert.assertEquals(dimension, analysisEntry.getKey());
+ JupiterAssertions.assertEquals(dimension, analysisEntry.getKey());
final ColumnAnalysis columnAnalysis = analysisEntry.getValue();
final boolean isString = schema.getColumnType().is(ValueType.STRING);
- Assert.assertEquals(dimension, schema.getColumnType().toString(),
columnAnalysis.getType());
- Assert.assertEquals(dimension, 0, columnAnalysis.getSize());
+ JupiterAssertions.assertEquals(dimension,
schema.getColumnType().toString(), columnAnalysis.getType());
+ JupiterAssertions.assertEquals(dimension, 0, columnAnalysis.getSize());
if (isString) {
if (analyses == null) {
- Assert.assertTrue(dimension, columnAnalysis.getCardinality() > 0);
+ JupiterAssertions.assertTrue(dimension,
columnAnalysis.getCardinality() > 0);
} else {
- Assert.assertEquals(dimension, 0,
columnAnalysis.getCardinality().longValue());
+ JupiterAssertions.assertEquals(dimension, 0,
columnAnalysis.getCardinality().longValue());
}
} else {
- Assert.assertNull(dimension, columnAnalysis.getCardinality());
+ JupiterAssertions.assertNull(dimension,
columnAnalysis.getCardinality());
}
}
for (String metric : TestIndex.DOUBLE_METRICS) {
final ColumnAnalysis columnAnalysis = columns.get(metric);
- Assert.assertEquals(metric, ValueType.DOUBLE.name(),
columnAnalysis.getType());
- Assert.assertEquals(metric, 0, columnAnalysis.getSize());
- Assert.assertNull(metric, columnAnalysis.getCardinality());
+ JupiterAssertions.assertEquals(metric, ValueType.DOUBLE.name(),
columnAnalysis.getType());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [ColumnAnalysis.getType](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11801)
##########
processing/src/test/java/org/apache/druid/query/metadata/SegmentAnalyzerTest.java:
##########
@@ -182,54 +183,54 @@
analyses
);
- Assert.assertEquals(1, results.size());
+ JupiterAssertions.assertEquals(1, results.size());
final SegmentAnalysis analysis = results.get(0);
- Assert.assertEquals(SegmentId.dummy("test_1").toString(),
analysis.getId());
+ JupiterAssertions.assertEquals(SegmentId.dummy("test_1").toString(),
analysis.getId());
final Map<String, ColumnAnalysis> columns = analysis.getColumns();
// Verify key order is the same as the underlying segment.
// This helps DruidSchema keep things in the proper order when it does
SegmentMetadata queries.
final List<Map.Entry<String, ColumnAnalysis>> entriesInOrder = new
ArrayList<>(columns.entrySet());
- Assert.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
- Assert.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
+ JupiterAssertions.assertEquals(ColumnHolder.TIME_COLUMN_NAME,
entriesInOrder.get(0).getKey());
+ JupiterAssertions.assertEquals(ColumnType.LONG,
entriesInOrder.get(0).getValue().getTypeSignature());
// Start from 1: skipping __time
for (int i = 0; i < TestIndex.DIMENSION_SCHEMAS.size(); i++) {
final DimensionSchema schema = TestIndex.DIMENSION_SCHEMAS.get(i);
final Map.Entry<String, ColumnAnalysis> analysisEntry =
entriesInOrder.get(i + 1 /* skip __time */);
final String dimension = schema.getName();
- Assert.assertEquals(dimension, analysisEntry.getKey());
+ JupiterAssertions.assertEquals(dimension, analysisEntry.getKey());
final ColumnAnalysis columnAnalysis = analysisEntry.getValue();
final boolean isString = schema.getColumnType().is(ValueType.STRING);
- Assert.assertEquals(dimension, schema.getColumnType().toString(),
columnAnalysis.getType());
- Assert.assertEquals(dimension, 0, columnAnalysis.getSize());
+ JupiterAssertions.assertEquals(dimension,
schema.getColumnType().toString(), columnAnalysis.getType());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking [ColumnAnalysis.getType](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11803)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
