FrankChen021 commented on code in PR #19950:
URL: https://github.com/apache/druid/pull/19950#discussion_r3766628915
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeon.java:
##########
@@ -187,10 +194,23 @@ private SegmentLoadingCapabilities
fetchSegmentLoadingCapabilities()
);
}
catch (Throwable th) {
- throw new RE(th, "Received error while fetching historical capabilities
from Server[%s].", serverId);
+ SegmentLoadingCapabilities defaultCapabilities =
getDefaultLoadingCapabilities();
Review Comment:
[P2] Preserve fatal JVM errors in fallback
The new catch converts any Error, including OutOfMemoryError, LinkageError,
or ThreadDeath, into a normal fallback peon. Preserve fatal errors and only
fall back for expected fetch/serialization exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
