FrankChen021 commented on code in PR #19300:
URL: https://github.com/apache/druid/pull/19300#discussion_r3791731689
##########
extensions-core/google-extensions/pom.xml:
##########
@@ -51,6 +51,7 @@
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-storage</artifactId>
<version>${com.google.cloud.storage.version}</version>
+ <scope>provided</scope>
Review Comment:
[P1] GCS runtime dependency is excluded
pull-deps filters out provided artifacts, but GoogleStorageDruidModule still
requires com.google.cloud.storage.Storage and StorageOptions. Normal GCS
deployments will lack the storage jar and fail with missing classes. Keep this
dependency runtime-scoped or package the jar and its transitives explicitly.
##########
pom.xml:
##########
@@ -128,15 +128,15 @@
<jacoco.version>0.8.14</jacoco.version>
<testcontainers.version>2.0.3</testcontainers.version>
<hibernate-validator.version>6.2.5.Final</hibernate-validator.version>
- <httpclient.version>4.5.13</httpclient.version>
+ <httpclient.version>4.5.14</httpclient.version>
<okhttp.version>5.3.2</okhttp.version>
<kubernetes.client.version>25.0.0-legacy</kubernetes.client.version>
<zookeeper.version>3.8.6</zookeeper.version>
- <checkerframework.version>3.48.1</checkerframework.version>
- <com.google.apis.client.version>2.2.0</com.google.apis.client.version>
-
<com.google.http.client.apis.version>1.42.3</com.google.http.client.apis.version>
+ <checkerframework.version>3.49.0</checkerframework.version>
+ <com.google.apis.client.version>2.9.0</com.google.apis.client.version>
Review Comment:
[P2] Register google-api-client 2.9.0
This changes com.google.api-client:google-api-client to 2.9.0, but
licenses.yaml still registers 2.2.0. The exact-GAV license checker will report
2.9.0 as missing and fail release validation. Update the license registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
