GWphua opened a new pull request, #19014: URL: https://github.com/apache/druid/pull/19014
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. --> <!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. --> <!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. --> <!-- If you are a committer, follow the PR action item checklist for committers: https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. --> ### Description #18591 introduced the capability to change the max number of K8s tasks created by Overlord, and we can track the values using `/druid/indexer/v1/k8s/taskrunner/executionconfig` API. #### Execution Config Returns Static Config by Default Currently, calling GET on the `/druid/indexer/v1/k8s/taskrunner/executionconfig` API will return an empty payload if we did not submit any dynamic configs via POST on the same API. Users who depend on the API to retrieve the currently effective K8s task runner information will not see the information before the first dynamic config change is submitted. Changed the API to return the effective config, so the users will always see what is currently being used. #### Release note <!-- Give your best effort to summarize your changes in a couple of sentences aimed toward Druid users. If your change doesn't have end user impact, you can skip this section. For tips about how to write a good release note, see [Release notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes). --> Prior to this change, GET `/druid/indexer/v1/k8s/taskrunner/executionconfig` will return an empty value when the dynamic config has not been updated via POST `/druid/indexer/v1/k8s/taskrunner/executionconfig`. This PR changes this behaviour to always reflect the dynamic config that will be used by the task runner to create K8s jobs. <hr> This PR has: - [x] been self-reviewed. - [x] a release note entry in the PR description. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
