nozjkoitop opened a new pull request, #20055:
URL: https://github.com/apache/druid/pull/20055

   ### Description
   
   The AWS SDK v2 version used by Druid sends CRC32 request checksums by 
default for S3 operations such as `DeleteObjects`. Some S3-compatible storage 
implementations do not support these checksum headers and reject requests with 
a content-hash mismatch, causing operations such as bulk segment kill tasks to 
fail
   
   This PR adds the `druid.s3.enableLegacyMd5` configuration property. When 
enabled, Druid applies the SDK-provided `LegacyMd5Plugin` to both synchronous 
and asynchronous S3 clients, restoring `Content-MD5` request checksums
   
   The option is disabled by default, leaving the existing behavior unchanged 
for AWS S3 and compatible storage implementations that support CRC32 checksums
   
   #### Release note
   
   S3-compatible storage users can set `druid.s3.enableLegacyMd5=true` to use 
legacy MD5 request checksums. The default remains `false`
   
   <hr>
   
   ##### Key changed/added classes in this PR
   - `AWSClientConfig`
   - `S3Utils`
   - `ServerSideEncryptingAmazonS3`
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to