FrankChen021 commented on code in PR #20056:
URL: https://github.com/apache/druid/pull/20056#discussion_r3804005137
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/IngestionDockerTest.java:
##########
@@ -54,14 +54,14 @@ protected EmbeddedDruidCluster
addServers(EmbeddedDruidCluster cluster)
return cluster
.useDefaultTimeoutForLatchableEmitter(240)
.useContainerFriendlyHostname()
+ .addServer(eventCollector)
Review Comment:
[P2] Do not leak embedded-test mode into containers
This makes the event collector the first embedded server, so
EmbeddedDruidCluster adds druid.extensions.modulesForEmbeddedTest before the
Docker resources start. DruidContainerResource copies common properties into
each container, but its exclusion list uses the misspelled plural
modulesForEmbeddedTests, leaving the actual property enabled. The containers
therefore run ExtensionsLoader in embedded-test filtering mode and can silently
skip configured extension modules. Remove this property from external service
configs using the correct key; apply the same fix to the backward-compatibility
and K3s paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
