FrankChen021 commented on code in PR #20059:
URL: https://github.com/apache/druid/pull/20059#discussion_r3813158182
##########
server/src/test/java/org/apache/druid/server/coordinator/duty/RunRulesTest.java:
##########
@@ -1024,7 +1026,8 @@ public void testRulesRunOnNonOvershadowedSegmentsOnly()
* Replicants - 3
* Random balancer strategy should not assign anything and not get into loop
as there are not enough nodes for replication
*/
- @Test(timeout = 5000L)
+ @Test
+ @Timeout(value = 5000L, unit = TimeUnit.MILLISECONDS)
Review Comment:
[P2] Timeout migration loses preemptive semantics
JUnit 4's timeout was preemptive, but bare Jupiter @Timeout defaults to
same-thread execution. A CPU-bound regression can therefore hang the test
worker instead of failing after five seconds. Preserve the original semantics
with ThreadMode.SEPARATE_THREAD or assertTimeoutPreemptively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
