FrankChen021 commented on code in PR #20061:
URL: https://github.com/apache/druid/pull/20061#discussion_r3813274946
##########
server/src/test/java/org/apache/druid/rpc/ServiceClientImplTest.java:
##########
@@ -75,24 +69,21 @@ public class ServiceClientImplTest
private ScheduledExecutorService exec;
- @Rule
- public MockitoRule mockitoRule =
MockitoJUnit.rule().strictness(Strictness.STRICT_STUBS);
-
- @Mock
private HttpClient httpClient;
- @Mock
private ServiceLocator serviceLocator;
private ServiceClient serviceClient;
- @Before
+ @BeforeEach
public void setUp()
{
+ httpClient = Mockito.mock(HttpClient.class);
Review Comment:
Fixed in 1bd9ba1cbb. Both tests now use the JUnit 5 MockitoExtension with
explicit Strictness.STRICT_STUBS and @Mock fields, and server adds the
test-scoped mockito-junit-jupiter dependency. Verified with both focused test
classes (34 tests), server test-compile, Checkstyle, SpotBugs, and git diff
--check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
