clintropolis commented on code in PR #20074:
URL: https://github.com/apache/druid/pull/20074#discussion_r3816537217
##########
processing/src/main/java/org/apache/druid/common/asyncresource/SettableAsyncResource.java:
##########
@@ -308,6 +315,17 @@ private boolean setInternal(Either<Throwable,
ResourceHolder<T>> value)
canceler = null;
callbacksToFire = drainCallbacks();
}
+
+ if (!didSet && value.isError()) {
+ // Nothing will ever surface this error: get() on a closed resource
throws "Closed" and the callbacks are gone,
+ // so log it rather than let a failure that lost a race with close()
vanish
+ if (value.error() instanceof CancellationException) {
+ LOG.debug(value.error(), "Resource canceled by close().");
+ } else {
+ LOG.warn(value.error(), "Resource failed after close().");
Review Comment:
ah oops yea, I changed this to only ever log at debug level in case it is
needed to troubleshoot issues, but otherwise wont pollute the logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
