clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r266626363
########## File path: server/src/main/java/org/apache/druid/metadata/MetadataSegmentManager.java ########## @@ -59,6 +60,8 @@ Collection<ImmutableDruidDataSource> getDataSources(); + Iterable<DataSegment> iterateAllSegments(); Review comment: Ok, my main complaint was less on using 'get' and more on 'iterate' over 'iterable', but I think maybe this is ok based on your explanation. I would likely check out the javadoc if i encountered this method, so I think it checks out? :+1: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org