FrankChen021 opened a new pull request, #20088:
URL: https://github.com/apache/druid/pull/20088
### Description
Convert `ScanQueryResultOrderingTest` from JUnit 5 `@ParameterizedClass` to
method-level `@ParameterizedTest` methods.
The parameter matrix and the three ordering assertions are unchanged. Each
method still receives every tuple from `constructorFeeder`; the change removes
the cost of creating and reporting thousands of parameterized test-class
containers.
### Performance benchmark
Measured locally with JDK 25 using the same focused Maven command before and
after the change:
```text
env JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-25.jdk/Contents/Home
\
/usr/bin/time -p mvn -B -q -pl processing \
-Dtest=ScanQueryResultOrderingTest \
-Dsurefire.failIfNoSpecifiedTests=false \
-Dweb.console.skip=true -Pskip-static-checks test
```
| Measurement | `master` | This PR |
| --- | ---: | ---: |
| Wall time | 316.02 s | 7.33 s |
| Improvement | | 97.68% faster |
### Test-count evidence
The converted run executed all 15,309 test cases. The Surefire report
contains the following evidence:
```text
$ grep -c '<testcase'
processing/target/surefire-reports/TEST-org.apache.druid.query.scan.ScanQueryResultOrderingTest.xml
15309
<testsuite ... tests="15309" errors="0" skipped="0" failures="0" ...>
```
This matches the unchanged matrix of 5,103 parameter tuples across three
test methods (`5,103 x 3 = 15,309`).
### Key changed/added classes
*
`processing/src/test/java/org/apache/druid/query/scan/ScanQueryResultOrderingTest.java`
### Test plan
- [x] Focused `ScanQueryResultOrderingTest` run under JDK 25
- [x] Verified 15,309 testcases executed
- [x] Verified zero failures and errors
This PR has:
- [x] been self-reviewed.
- [x] added or modified existing tests or test infrastructure to cover the
changed path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
