FrankChen021 commented on code in PR #20063:
URL: https://github.com/apache/druid/pull/20063#discussion_r3821789388
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -736,6 +734,7 @@ public void run()
.builder()
.withDataSourcesSnapshot(dataSourcesSnapshot)
.withDynamicConfigs(metadataManager.configs().getCurrentDynamicConfig())
+
.withRetentionRulesSnapshot(metadataManager.rules().getRulesSnapshot())
Review Comment:
Reviewed 21 of 21 changed files.
The ordering guidance does not make the two snapshots coherent. During alias
removal, this Coordinator can see the new alias map before
SQLMetadataRuleManager.poll() sees the rule deletion, causing the old alias
rule to resolve to no tiers and drop all replicas. Reordering reads only covers
one update direction; a coherent pair or unresolved-alias guard is still needed.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
