drcrallen commented on a change in pull request #7273: Fix some IntelliJ
inspections
URL: https://github.com/apache/incubator-druid/pull/7273#discussion_r266636877
##########
File path:
extensions-contrib/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java
##########
@@ -246,15 +246,14 @@ static String typeStringFromParseSpec(ParseSpec
parseSpec)
builder.append(parseSpec.getTimestampSpec().getTimestampColumn()).append(":string");
// the typeString seems positionally dependent, so repeated timestamp
column causes incorrect mapping
if (parseSpec.getDimensionsSpec().getDimensionNames().size() > 0) {
- builder.append(",");
- builder.append(String.join(
Review comment:
It's not about it being ok, it is about mixing in changes that are not
germane to the intention of the PR, which is a dangerous process.
Things like "does this have adequate test coverage" make it harder to review
in the context of the pr.
Unless this change is required for the intellij inspections for some reason,
can it be moved to its own PR please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
