FrankChen021 opened a new pull request, #20106: URL: https://github.com/apache/druid/pull/20106
### Description Complete the JUnit 5 assertion migration in `DataSourceCompactibleSegmentIteratorTest`. The file already imports `org.junit.jupiter.api.Assertions`, but the two tests added by PR #20027 retained eight `Assert.assert...` calls. When PR #20059 changed the import during its migration, those calls became unresolved in the combined master tree. ### Evidence - The post-merge master run for PR #20059 failed during `server` test compilation: [Unit & Integration tests CI](https://github.com/apache/druid/actions/runs/32474226169). - The same `cannot find symbol: variable Assert` error appeared in Static Checks CI and CodeQL: [Static Checks](https://github.com/apache/druid/actions/runs/32474225547), [CodeQL](https://github.com/apache/druid/actions/runs/32474225592). - PR #20059's own checks were green on head `414ddb`: [PR checks](https://github.com/apache/druid/actions/runs/32258218855). - PR #20027 merged after those checks and before #20059, adding the two tests with the stale `Assert` calls: [PR #20027](https://github.com/apache/druid/pull/20027). This explains why the PR checks passed while the post-merge master build failed. ### Changes Replace the eight remaining `Assert` calls with `Assertions`. ### Testing - `mvn test -pl server -am -Dtest="org.apache.druid.server.compaction.DataSourceCompactibleSegmentIteratorTest" -Dsurefire.failIfNoSpecifiedTests=false -DforkCount=0 -Pskip-static-checks -Dweb.console.skip=true -T1` - Result: 5 tests passed, 0 failures, 0 errors. No release note is needed; this is a test-only build fix. This PR has: - [x] been self-reviewed. - [x] added or updated tests or test assertions for the affected code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
