FrankChen021 opened a new pull request, #20125: URL: https://github.com/apache/druid/pull/20125
Part of [#13948](https://github.com/apache/druid/issues/13948). ### Summary Complete the remaining JUnit 5 migration cleanup across the repository. - Migrate the remaining JUnit 4 test classes and helpers to JUnit 5. - Remove obsolete JUnit 4, Vintage, JUnitParams, migration-support, system-rules, and JUnit benchmark dependencies. - Remove obsolete JUnit migration recipes, OpenRewrite testing-framework support, and `dev/validate-junit5-usage`. - Extend `TemporaryFolderExtension` with `classScoped()` and `testCaseScoped()` lifecycles and migrate eligible temporary-directory usage. - Move `CostBalancerStrategyBenchmark` into the benchmarks module and preserve its benchmark behavior using JMH. - Remove obsolete test rules and simplify migrated test helpers. - Retain Hamcrest and opentest4j only where active tests still require them. ### JDK 25 Schemaless test stability Migrate `SchemalessTestSimpleTest` from JUnit 4 class-level parameterization to JUnit 5 method-level parameterization. The fixture lifecycle and cleanup changes incorporate the approach from [PR #20121](https://github.com/apache/druid/pull/20121): - Create independent fixtures for each parameterized test invocation. - Close each segment with try-with-resources. - Close intermediate mapped indexes after creating the merged index. - Keep the existing `@Disabled` annotation only for the pre-existing TopN null-handling issue. These changes prevent the intermittent JDK 25 direct-buffer crash observed during the original migration attempt. ### Validation - Affected processing, indexing-service, server, and embedded-tests modules compile successfully. - Focused migrated tests pass on JDK 25. - Checkstyle and SpotBugs pass with no violations or reported bugs. - The Kafka simulation tests pass with the required Hamcrest test dependency. - `git diff --check` passes. This PR contains test and build/test-tooling changes only; there are no user-facing behavior changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
