aho135 commented on code in PR #19627:
URL: https://github.com/apache/druid/pull/19627#discussion_r3845375076
##########
server/src/main/java/org/apache/druid/server/metrics/GroupByStatsMonitor.java:
##########
@@ -68,6 +68,7 @@ public boolean doMonitor(ServiceEmitter emitter)
emitter.emit(builder.setMetric("mergeBuffer/maxAcquisitionTimeNs",
statsContainer.getMaxMergeBufferAcquisitionTimeNs()));
emitter.emit(builder.setMetric("mergeBuffer/bytesUsed",
statsContainer.getTotalMergeBufferUsedBytes()));
emitter.emit(builder.setMetric("mergeBuffer/maxBytesUsed",
statsContainer.getMaxMergeBufferUsedBytes()));
+ emitter.emit(builder.setMetric("mergeBuffer/maxSpillProximity",
statsContainer.getMaxSpillProximity()));
Review Comment:
Good catch — done in 4e00753. Added `mergeBuffer/maxSpillProximity` to
`prometheus-emitter/src/main/resources/defaultMetrics.json` as a no-dimension
gauge (matching the sibling `mergeBuffer/*` entries), and added
`MetricsTest.testMergeBufferMaxSpillProximityRegisteredAsGauge` asserting the
default mapping resolves it to a `Gauge` with only the standard service/host
labels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
