FrankChen021 commented on PR #20136: URL: https://github.com/apache/druid/pull/20136#issuecomment-5404594257
Codex dependency triage at exact head 9f85fe673f5be3cf822aba9b9b9386ca904c26fe, compared with upstream master 20d733e735b7b4691624b93e4efba760ac6525ee: - The Caliper 0.5-rc1 -> 1.0-beta-3 bump removes the com.google.caliper.Runner and SimpleBenchmark classes used by five Druid benchmark classes. - All 22 terminal failed checks are PR-caused test-compilation failures. The same missing classes appear in unit/QTest, validate-dist, static, strict, packaging, web, openrewrite, and CodeQL derivative jobs. - No production API, deployment/client/configuration, wire/serialization, persistence/stored-data, or extension/plugin SPI change was found. - Restoring the old version would abandon this PR's upgrade intent. Migrating the five legacy benchmarks to current Caliper/JMH requires benchmark lifecycle/API and performance validation, which is a separate high-effort change rather than a surgical dependency fix. Closing this PR as high effort / not safe to approve. No merge was performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
