FrankChen021 commented on code in PR #20128:
URL: https://github.com/apache/druid/pull/20128#discussion_r3853025159
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeon.java:
##########
@@ -187,7 +193,9 @@ private SegmentLoadingCapabilities
fetchSegmentLoadingCapabilities()
);
}
catch (Throwable th) {
- throw new RE(th, "Received error while fetching historical capabilities
from Server[%s].", serverId);
+ log.warn(th, "Failed to fetch loading capabilities from server[%s].
Using default capabilities.", serverId);
Review Comment:
[P2] Fallback swallows fatal and interruption signals
The Throwable catch now converts fatal Errors and InterruptedException into
a normal peon. This can mask JVM-level failures and clear interruption without
restoring the thread flag. Catch only expected request/parsing exceptions,
while rethrowing fatal errors and preserving interruption.
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeon.java:
##########
@@ -187,7 +193,9 @@ private SegmentLoadingCapabilities
fetchSegmentLoadingCapabilities()
);
}
catch (Throwable th) {
- throw new RE(th, "Received error while fetching historical capabilities
from Server[%s].", serverId);
+ log.warn(th, "Failed to fetch loading capabilities from server[%s].
Using default capabilities.", serverId);
+ int batchSize = config.getBatchSize() == null ? 1 :
config.getBatchSize();
+ return new SegmentLoadingCapabilities(batchSize, batchSize);
Review Comment:
[P2] Transient failures permanently throttle the peon
serverCapabilities is initialized once and cached for the peon's lifetime.
After a temporary timeout, 5xx, or malformed response, the stored fallback
remains active indefinitely; with no configured batchSize this reduces normal
and turbo loading to one segment per batch. Retry capability discovery or
refresh the fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
