shoemoney opened a new pull request, #20151:
URL: https://github.com/apache/druid/pull/20151
### Description
Broker can return HTTP 429 or 503 with an HTML error page (for example from
a load balancer or reverse proxy) instead of the expected JSON.
DirectDruidClient at 242 enqueues the raw body and later JsonParserIterator
tries to parse it as JSON, which fails with a JsonParseException for 0x3c ('<')
and masks the real capacity error.
Fix checks response status and Content-Type before enqueue in handleResponse:
- If status is 429 or 503, throw QueryCapacityExceededException with status
and a body preview before any JSON parsing.
- If Content-Type is text/html or the first non-whitespace byte is '<'
instead of '{' or '[', fail fast with a meaningful QueryInterruptedException
preview instead of a generic JsonParseException.
This preserves the correct exception type for capacity errors and avoids
HTML being misreported as a JSON parse failure.
### Testing
- RED to GREEN verified locally
- DirectDruidClientTest 12 tests pass before and after the change
- Formatter blast radius limited to DirectDruidClient.java
### Release note
Fix broker HTML 429/503 responses being masked as JsonParseException in
DirectDruidClient.
<hr>
##### Key changed/added classes in this PR
* DirectDruidClient
This PR has:
- [x] been self-reviewed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
