yurmix commented on a change in pull request #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266671149
########## File path: extensions-contrib/moving-average-query/src/test/java/org/apache/druid/query/movingaverage/MovingAverageIterableTest.java ########## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.movingaverage; + +import org.apache.druid.data.input.MapBasedRow; +import org.apache.druid.data.input.Row; +import org.apache.druid.java.util.common.guava.Sequence; +import org.apache.druid.java.util.common.guava.Sequences; +import org.apache.druid.query.aggregation.AggregatorFactory; +import org.apache.druid.query.aggregation.FilteredAggregatorFactory; +import org.apache.druid.query.aggregation.LongSumAggregatorFactory; +import org.apache.druid.query.dimension.DefaultDimensionSpec; +import org.apache.druid.query.dimension.DimensionSpec; +import org.apache.druid.query.filter.DimFilter; +import org.apache.druid.query.filter.SelectorDimFilter; +import org.apache.druid.query.movingaverage.averagers.AveragerFactory; +import org.apache.druid.query.movingaverage.averagers.ConstantAveragerFactory; +import org.apache.druid.query.movingaverage.averagers.LongMeanAveragerFactory; +import org.joda.time.DateTime; +import org.joda.time.chrono.ISOChronology; +import org.junit.Test; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; + +import static org.hamcrest.CoreMatchers.anyOf; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.CoreMatchers.not; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertThat; +import static org.junit.Assert.assertTrue; + +/** + * + */ +public class MovingAverageIterableTest +{ + private static final DateTime JAN_1 = new DateTime(2017, 1, 1, 0, 0, 0, 0, ISOChronology.getInstanceUTC()); + private static final DateTime JAN_2 = new DateTime(2017, 1, 2, 0, 0, 0, 0, ISOChronology.getInstanceUTC()); + private static final DateTime JAN_3 = new DateTime(2017, 1, 3, 0, 0, 0, 0, ISOChronology.getInstanceUTC()); + private static final DateTime JAN_4 = new DateTime(2017, 1, 4, 0, 0, 0, 0, ISOChronology.getInstanceUTC()); + private static final DateTime JAN_5 = new DateTime(2017, 1, 5, 0, 0, 0, 0, ISOChronology.getInstanceUTC()); + private static final DateTime JAN_6 = new DateTime(2017, 1, 6, 0, 0, 0, 0, ISOChronology.getInstanceUTC()); + private static final DateTime JAN_7 = new DateTime(2017, 1, 7, 0, 0, 0, 0, ISOChronology.getInstanceUTC()); + + private static final String GENDER = "gender"; + private static final String AGE = "age"; + private static final String COUNTRY = "country"; + + private static final Map<String, Object> dims1 = new HashMap<>(); + private static final Map<String, Object> dims2 = new HashMap<>(); + private static final Map<String, Object> dims3 = new HashMap<>(); + + static { + dims1.put(GENDER, "m"); + dims1.put(AGE, "10"); + dims1.put(COUNTRY, "US"); + + dims2.put(GENDER, "f"); + dims2.put(AGE, "8"); + dims2.put(COUNTRY, "US"); + + dims3.put(GENDER, "u"); + dims3.put(AGE, "5"); + dims3.put(COUNTRY, "UK"); + } + + @Test + public void testNext() + { + + Collection<DimensionSpec> dims = Arrays.asList( + new DefaultDimensionSpec(GENDER, GENDER), + new DefaultDimensionSpec(AGE, AGE), + new DefaultDimensionSpec(COUNTRY, COUNTRY) + ); + + Sequence<RowBucket> dayBuckets = Sequences.simple(Arrays.asList( + new RowBucket(JAN_1, Arrays.asList( + new MapBasedRow(JAN_1, dims1), + new MapBasedRow(JAN_1, dims2) + )), + new RowBucket(JAN_2, Collections.singletonList( + new MapBasedRow(JAN_2, dims1) + )), + new RowBucket(JAN_3, Collections.emptyList()), + new RowBucket(JAN_4, Arrays.asList( + new MapBasedRow(JAN_4, dims2), + new MapBasedRow(JAN_4, dims3) + )) + )); + + Iterable<Row> iterable = new MovingAverageIterable( + dayBuckets, + dims, + Collections.singletonList(new ConstantAveragerFactory("noop", 1, 1.1f)), + Collections.emptyList(), + Collections.emptyList() + ); + + Iterator<Row> iter = iterable.iterator(); + + assertTrue(iter.hasNext()); + Row r = iter.next(); + assertEquals(JAN_1, r.getTimestamp()); + assertEquals("m", r.getRaw(GENDER)); + + assertTrue(iter.hasNext()); + r = iter.next(); + assertEquals(JAN_1, r.getTimestamp()); + assertEquals("f", r.getRaw(GENDER)); + + assertTrue(iter.hasNext()); + r = iter.next(); + assertEquals(JAN_2, r.getTimestamp()); + assertEquals("m", r.getRaw(GENDER)); + + assertTrue(iter.hasNext()); + r = iter.next(); + assertEquals(JAN_2, r.getTimestamp()); + assertEquals("f", r.getRaw(GENDER)); + + assertTrue(iter.hasNext()); + r = iter.next(); + Row r2 = r; + assertEquals(JAN_3, r.getTimestamp()); + assertEquals("US", r.getRaw(COUNTRY)); + + assertTrue(iter.hasNext()); + r = iter.next(); + assertEquals(JAN_3, r.getTimestamp()); + assertEquals("US", r.getRaw(COUNTRY)); + assertThat(r.getRaw(AGE), not(equalTo(r2.getRaw(AGE)))); + + assertTrue(iter.hasNext()); + r = iter.next(); + assertEquals(JAN_4, r.getTimestamp()); + assertEquals("f", r.getRaw(GENDER)); + + assertTrue(iter.hasNext()); + r = iter.next(); + assertEquals(JAN_4, r.getTimestamp()); + assertEquals("u", r.getRaw(GENDER)); + + assertTrue(iter.hasNext()); + r = iter.next(); + assertEquals(JAN_4, r.getTimestamp()); + assertEquals("m", r.getRaw(GENDER)); + + assertFalse(iter.hasNext()); + } + + @Test + public void testAveraging() + { + + Map<String, Object> event1 = new HashMap<>(); + Map<String, Object> event2 = new HashMap<>(); + Map<String, Object> event3 = new HashMap<>(); + Map<String, Object> event4 = new HashMap<>(); + + List<DimensionSpec> ds = new ArrayList<>(); + ds.add(new DefaultDimensionSpec("gender", "gender")); + + event1.put("gender", "m"); + event1.put("pageViews", 10L); + Row row1 = new MapBasedRow(JAN_1, event1); + + event2.put("gender", "m"); + event2.put("pageViews", 20L); + Row row2 = new MapBasedRow(JAN_2, event2); + + event3.put("gender", "m"); + event3.put("pageViews", 30L); + Row row3 = new MapBasedRow(JAN_3, event3); + + event4.put("gender", "f"); + event4.put("pageViews", 40L); + Row row4 = new MapBasedRow(JAN_2, event4); Review comment: Fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
