capistrant commented on code in PR #20155:
URL: https://github.com/apache/druid/pull/20155#discussion_r3859233145
##########
server/src/test/java/org/apache/druid/server/coordinator/duty/RunRulesPartialLoadPlacementTest.java:
##########
@@ -221,31 +348,97 @@ private CoordinatorRunStats runRules(DruidCluster
cluster, Rule rule, DataSegmen
)
.withUsedSegments(segments)
.withBalancerStrategy(balancerStrategy)
- .withDynamicConfigs(
Review Comment:
I removed because using the non-default segment loading configs seemed odd.
we should either test default or both paths, not the non default. I think I am
the one who created this class I must have not been thinking on this config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
