FrankChen021 commented on PR #20160: URL: https://github.com/apache/druid/pull/20160#issuecomment-5437424631
Clarification on the JwtAuthenticatorTest updates:\n\nThese changes are test-only and do not change Druid runtime behavior. The tests mock TokenValidator and construct IDTokenClaimsSet directly. oauth2-oidc-sdk 10.8 allowed the mocked object to be constructed with an empty audience and null time fields, while 11.38.2 enforces those ID-token invariants. The fixtures therefore provide aud=testClient and non-null test timestamps.\n\nThe actual Nimbus validation path in 10.8 already rejected a missing or empty aud and required it to contain the configured client ID, as well as requiring exp and iat; 11.38.2 retains those checks. Therefore this PR does not newly reject tokens without aud: they were already invalid under the normal Druid validator path. No production Druid Java code was changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
