zhang-arvin commented on PR #20094: URL: https://github.com/apache/druid/pull/20094#issuecomment-5440801804
@FrankChen021 Thanks for the review! I have fixed the GroupByQuery check: **P1 fix**: Moved the `GroupByQuery` check out of the `stage <= SELECT_PROJECT` block to be an independent condition. Previously, the GroupByQuery check was unreachable because it was nested inside the `whereFilter == null` branch which only executes before the AGGREGATE stage — but GroupByQuery only appears at or after AGGREGATE. The fix ensures that when the left side query is a GroupByQuery, it is always used as a subquery datasource regardless of the current stage, preventing the UNNEST from reading pre-grouping rows and producing duplicates. Note: The CI failures (17/21) are caused by master branch drift — `DataSourceCompactibleSegmentIteratorTest` was migrated from JUnit 4 to JUnit 5 on master. This is unrelated to the PR changes. I will rebase onto master in a follow-up push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
