zhang-arvin commented on PR #20092: URL: https://github.com/apache/druid/pull/20092#issuecomment-5440891114
@FrankChen021 The code fixes for all three issues are already in place: 1. **P1 (plus→minus)**: `resetInternal()` already uses `currentMetadata.minus(resetMetadata)` to remove stale offsets instead of merging them back. 2. **P2 (future offset)**: `KafkaIndexTaskRunner` now distinguishes between offsets below earliest (re-throws for supervisor reset) and future offsets (waits and retries). 3. **P2 (task group)**: After reset, affected task groups are now removed from `newTaskGroups` so the next run cycle rebuilds them with correct offsets. The CI failures (19/21) are caused by master branch drift — `DataSourceCompactibleSegmentIteratorTest` was migrated from JUnit 4 to JUnit 5 on master, which is unrelated to the PR changes. I will rebase onto master to resolve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
