FrankChen021 commented on code in PR #19236:
URL: https://github.com/apache/druid/pull/19236#discussion_r3889506239
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java:
##########
@@ -540,6 +541,11 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
initializeSubTaskCleaner();
this.toolbox = toolbox;
+ // Propagate auth context to input source for credential vending (e.g.,
Iceberg REST Catalog)
+ if (baseInputSource instanceof TaskAuthContextAware) {
Review Comment:
[P1] Propagate auth context to ordinary index tasks
This is the only ingestion-framework hook added for TaskAuthContextAware,
but IcebergInputSource is also usable by ordinary index tasks. IndexTask
obtains the source at IndexTask.java:462 and
AbstractBatchIndexTask.inputSourceReader calls it without setTaskAuthContext,
so a normal index task never forwards its context to RestIcebergCatalog;
catalog authentication and credential vending then fail. Add the propagation to
the common batch path or every input-source execution path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
