FrankChen021 commented on code in PR #19432:
URL: https://github.com/apache/druid/pull/19432#discussion_r3889538703
##########
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java:
##########
@@ -77,7 +79,9 @@ public LDAPCredentialsValidator(
@JsonProperty("credentialIterations") Integer credentialIterations,
@JsonProperty("credentialVerifyDuration") Integer
credentialVerifyDuration,
@JsonProperty("credentialMaxDuration") Integer credentialMaxDuration,
- @JsonProperty("credentialCacheSize") Integer credentialCacheSize
+ @JsonProperty("credentialCacheSize") Integer credentialCacheSize,
+ @JsonProperty("groupBaseDn") String groupBaseDn,
Review Comment:
not true
##########
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java:
##########
@@ -77,7 +79,9 @@ public LDAPCredentialsValidator(
@JsonProperty("credentialIterations") Integer credentialIterations,
@JsonProperty("credentialVerifyDuration") Integer
credentialVerifyDuration,
@JsonProperty("credentialMaxDuration") Integer credentialMaxDuration,
- @JsonProperty("credentialCacheSize") Integer credentialCacheSize
+ @JsonProperty("credentialCacheSize") Integer credentialCacheSize,
+ @JsonProperty("groupBaseDn") String groupBaseDn,
Review Comment:
[P2] Preserve the existing public constructor
Adding groupBaseDn and groupSearch to the only public URL-based constructor
removes the previous 10-argument signature. Direct Java callers will fail to
compile, and already-compiled integrations can fail with NoSuchMethodError even
when reverse group lookup is unused. Keep a delegating overload for the
existing signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
