kfaraz commented on code in PR #20199: URL: https://github.com/apache/druid/pull/20199#discussion_r3896339961
########## docs/operations/metrics.md: ########## @@ -469,7 +469,9 @@ These metrics are emitted by the Druid Coordinator in every run of the correspon |`tier/historical/count`|Number of available historical nodes in each tier. The `tierAlias` dimension is emitted only when the tier belongs to an alias configured via [`historicalTierAliases`](../configuration/index.md#dynamic-configuration), and can be used to aggregate metrics across the tiers in an alias.|`tier`, `tierAlias`|Varies| |`tier/replication/factor`|Configured maximum replication factor in each tier. The `tierAlias` dimension is emitted only when the tier belongs to an alias configured via [`historicalTierAliases`](../configuration/index.md#dynamic-configuration).|`tier`, `tierAlias`|Varies| |`tier/required/capacity`|Total capacity in bytes required in each tier. The `tierAlias` dimension is emitted only when the tier belongs to an alias configured via [`historicalTierAliases`](../configuration/index.md#dynamic-configuration).|`tier`, `tierAlias`|Varies| -|`tier/total/capacity`|Total capacity in bytes available in each tier. The `tierAlias` dimension is emitted only when the tier belongs to an alias configured via [`historicalTierAliases`](../configuration/index.md#dynamic-configuration).|`tier`, `tierAlias`|Varies| +|`tier/total/capacity`|Total capacity in bytes available in each tier. Can be greater than physical disk capacity if using virtual storage. The `tierAlias` dimension is emitted only when the tier belongs to an alias configured via [`historicalTierAliases`](../configuration/index.md#dynamic-configuration).|`tier`, `tierAlias`|Varies| Review Comment: With virtual storage, I feel `total/capacity` could now be ambiguous. Does this metric currently (before this PR) report the total virtual capacity or the total physical capacity? Since we are revisiting these metrics, I feel we could distinguish them by naming them something like: - `tier/storage/required` - `tier/storage/physicalCapacity` - `tier/storage/virtualCapacity` - `tier/storage/used` - and deprecated the existing `tier/total/capacity` metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
