kfaraz commented on code in PR #20236:
URL: https://github.com/apache/druid/pull/20236#discussion_r3932454732


##########
owasp-dependency-check-suppressions.xml:
##########
@@ -274,6 +320,69 @@
     <cve>CVE-2025-58057</cve> <!-- Netty 3.x not affected; compression issue 
only in 4.x -->
     <cve>CVE-2026-33870</cve> <!-- We don't use HttpPostRequestDecoder -->
     <cve>CVE-2026-33871</cve> <!-- Netty 3.x not affected; HTTP/2 issues only 
in 4.x -->
+    <cve>CVE-2026-44893</cve> <!-- We don't use the HAProxy codec -->
+    <cve>CVE-2026-44250</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-48059</cve> <!-- We don't use the HAProxy codec -->
+    <cve>CVE-2026-44890</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-44891</cve> <!-- We don't use the STOMP codec -->
+    <cve>CVE-2026-50011</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-59901</cve> <!-- We don't use Netty's Bzip2Decoder; Druid 
uses Apache Commons Compress for bzip2 -->
+    <cve>CVE-2026-62380</cve> <!-- We don't use the SOCKS codec; Druid uses 
HTTP CONNECT proxy tunneling -->
+    <cve>CVE-2026-59898</cve> <!-- Server-side WebSocket vulnerability; 
Druid's HTTP server is Jetty, not Netty -->
+    <cve>CVE-2026-59899</cve> <!-- Server-side HttpContentEncoder 
vulnerability; Druid uses Netty 3.x as HTTP client only -->
+    <cve>CVE-2026-42587</cve> <!-- Affects brotli/zstd/snappy decompression 
added in Netty 4.x; Netty 3.x only supports gzip/deflate -->
+    <cve>CVE-2026-42586</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-44248</cve> <!-- We don't use the MQTT codec -->
+    <cve>CVE-2026-44249</cve> <!-- We don't use Netty's IpSubnetFilterRule; 
Druid uses Jetty for HTTP access control -->
+    <cve>CVE-2026-45416</cve> <!-- Server-side TLS SNI vulnerability; Druid 
uses Netty 3.x as TLS client only, never as a server -->
+    <cve>CVE-2026-42581</cve> <!-- Server-side HTTP request smuggling; Druid's 
HTTP server is Jetty, not Netty -->
+    <cve>CVE-2026-45674</cve> <!-- Affects netty-resolver-dns which Druid 
doesn't use; Druid uses JDK DNS resolution -->
+    <cve>CVE-2026-48006</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-42585</cve> <!-- Server-side HTTP request smuggling; Druid's 
HTTP server is Jetty, not Netty -->
+    <cve>CVE-2026-42584</cve> <!-- HttpClientCodec response desynchronization 
in Netty 4.x codec; Druid uses Netty 3.x's HttpClientCodec which has a 
different implementation -->

Review Comment:
   Hmm, this does seem like a valid concern.
   The [VE-2026-42584](https://nvd.nist.gov/vuln/detail/cve-2026-42584) does 
seem to affect all Netty versions lower than `4.1.133`.
   Let me double check on what can be done here, because upgrading Netty3 to 
Netty4 has already been discussed and there is also a PR (#19754 ) but we 
cannot block Druid 38 release on that.



##########
owasp-dependency-check-suppressions.xml:
##########
@@ -274,6 +320,69 @@
     <cve>CVE-2025-58057</cve> <!-- Netty 3.x not affected; compression issue 
only in 4.x -->
     <cve>CVE-2026-33870</cve> <!-- We don't use HttpPostRequestDecoder -->
     <cve>CVE-2026-33871</cve> <!-- Netty 3.x not affected; HTTP/2 issues only 
in 4.x -->
+    <cve>CVE-2026-44893</cve> <!-- We don't use the HAProxy codec -->
+    <cve>CVE-2026-44250</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-48059</cve> <!-- We don't use the HAProxy codec -->
+    <cve>CVE-2026-44890</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-44891</cve> <!-- We don't use the STOMP codec -->
+    <cve>CVE-2026-50011</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-59901</cve> <!-- We don't use Netty's Bzip2Decoder; Druid 
uses Apache Commons Compress for bzip2 -->
+    <cve>CVE-2026-62380</cve> <!-- We don't use the SOCKS codec; Druid uses 
HTTP CONNECT proxy tunneling -->
+    <cve>CVE-2026-59898</cve> <!-- Server-side WebSocket vulnerability; 
Druid's HTTP server is Jetty, not Netty -->
+    <cve>CVE-2026-59899</cve> <!-- Server-side HttpContentEncoder 
vulnerability; Druid uses Netty 3.x as HTTP client only -->
+    <cve>CVE-2026-42587</cve> <!-- Affects brotli/zstd/snappy decompression 
added in Netty 4.x; Netty 3.x only supports gzip/deflate -->
+    <cve>CVE-2026-42586</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-44248</cve> <!-- We don't use the MQTT codec -->
+    <cve>CVE-2026-44249</cve> <!-- We don't use Netty's IpSubnetFilterRule; 
Druid uses Jetty for HTTP access control -->
+    <cve>CVE-2026-45416</cve> <!-- Server-side TLS SNI vulnerability; Druid 
uses Netty 3.x as TLS client only, never as a server -->
+    <cve>CVE-2026-42581</cve> <!-- Server-side HTTP request smuggling; Druid's 
HTTP server is Jetty, not Netty -->
+    <cve>CVE-2026-45674</cve> <!-- Affects netty-resolver-dns which Druid 
doesn't use; Druid uses JDK DNS resolution -->
+    <cve>CVE-2026-48006</cve> <!-- We don't use the Redis codec -->
+    <cve>CVE-2026-42585</cve> <!-- Server-side HTTP request smuggling; Druid's 
HTTP server is Jetty, not Netty -->
+    <cve>CVE-2026-42584</cve> <!-- HttpClientCodec response desynchronization 
in Netty 4.x codec; Druid uses Netty 3.x's HttpClientCodec which has a 
different implementation -->

Review Comment:
   Hmm, this does seem like a valid concern.
   The [CVE-2026-42584](https://nvd.nist.gov/vuln/detail/cve-2026-42584) does 
seem to affect all Netty versions lower than `4.1.133`.
   Let me double check on what can be done here, because upgrading Netty3 to 
Netty4 has already been discussed and there is also a PR (#19754 ) but we 
cannot block Druid 38 release on that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to