FrankChen021 commented on code in PR #19002:
URL: https://github.com/apache/druid/pull/19002#discussion_r3934325537
##########
pom.xml:
##########
@@ -414,9 +414,9 @@
<version>1.9.25</version>
</dependency>
<dependency>
- <groupId>org.jetbrains</groupId>
- <artifactId>annotations</artifactId>
- <version>26.0.2</version>
+ <groupId>org.jetbrains.kotlin</groupId>
+ <artifactId>kotlin-stdlib-jdk8</artifactId>
Review Comment:
[P1] Register Kotlin JDK8 license version
Adding parent management for org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.25
changes the version pulled by extensions-core/kubernetes-extensions, but the
only registry entry for this artifact is the grouped 1.8.21 record in
licenses.yaml. Because the license checker matches the exact
group/artifact/version tuple, apache-release/validate-dist will fail until a
1.9.25 entry is added, or the dependency remains at the registered version.
##########
pom.xml:
##########
@@ -930,6 +947,11 @@
<artifactId>protobuf-java</artifactId>
<version>${protobuf.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.api.grpc</groupId>
+ <artifactId>proto-google-common-protos</artifactId>
Review Comment:
[P1] Register proto license version
Managing com.google.api.grpc:proto-google-common-protos at 2.48.0 also
changes the transitive compile dependency in extensions-core/google-extensions,
while licenses.yaml still registers only 2.28.0.
distribution/bin/check-licenses.py keys entries by the exact
group/artifact/version tuple, so the apache-release validate-dist license check
will report 2.48.0 as missing. Add the 2.48.0 registry record, or scope this
management entry if the Google extension is not meant to move.
##########
pom.xml:
##########
@@ -620,7 +637,7 @@
<dependency>
<groupId>com.github.luben</groupId>
<artifactId>zstd-jni</artifactId>
- <version>1.5.2-3</version>
+ <version>1.5.6-6</version>
Review Comment:
[P1] Update Zstd-dependent size assertions
The zstd-jni upgrade changes the serialized size produced by the existing
ZSTD cases, but the hard-coded expected values in
processing/src/test/java/org/apache/druid/segment/serde/cell/BlockCompressedPayloadWriterReaderTest.java
and CellWriterReaderTest.java remain 796 and 845. The JDK21 unit checks for
this head report 599 vs 796 and 648 vs 845 respectively. Please update the
expectations after validating the new codec output, while retaining
compatibility coverage for existing encoded data, so this does not merge with
known failing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
