FrankChen021 commented on PR #20280: URL: https://github.com/apache/druid/pull/20280#issuecomment-5584195186
Dependency compatibility review for exact head 9cc01681866a95d08e521801b974020aef019ca6 (base 33f7f778dfc2d8b06ca7c1d7a93f54f162526cee). Release inventory: - Source: Okio 3.18.1. - Target: Okio 3.18.2. - Published stable transitions in scope: 3.18.1 -> 3.18.2; no intermediate stable release. - Upstream evidence: https://github.com/lysine-dev/okio/compare/parent-3.18.1...parent-3.18.2. The target contains the release-preparation commit and the base64-padding fix. The only source changes are Apple/non-Apple ByteString no-argument base64() and base64Url() implementations changing includePadding=false to true. This restores the pre-3.18.0 behavior. The JVM ByteString implementation is unchanged. Druid impact and required categories: | Category | Status | Evidence | | --- | --- | --- | | API/ABI | SAFE | No public signature removal; Druid has no direct com.squareup.okio imports or Okio API calls. | | Runtime | SAFE | The target restores expected padded output for deprecated no-argument methods; JVM implementation is unchanged and OkHttp/Fabric8 consumers remain on compatible 3.18.2 artifacts. | | Configuration | SAFE | Only Maven version management changes; no Druid configuration surface changes. | | Serialization/wire | SAFE | No Druid wire or serialized format changes; the only upstream behavior change restores historical Base64 padding, and Druid has no direct Okio Base64 use. | | Persistence | SAFE | No segment, metadata, storage, or persistence code changes. | | Clients | SAFE | Kubernetes/OkHttp client APIs are unchanged; Druid does not expose or call Okio directly. | | Transitive dependencies | SAFE | Focused Maven dependency-tree validation on protobuf, kubernetes, and kubernetes-overlord resolves okio and okio-jvm consistently at 3.18.2; the PR now aligns both managed coordinates. | | Licenses | SAFE | Okio remains Apache 2.0; both affected 3.18.1 license records are updated to 3.18.2. The separate existing 1.17.2 record is retained for its distinct Kubernetes-client lineage. | | Extension/plugin SPI | SAFE | No Druid extension, plugin, service-loader, or SPI changes. | Result: SAFE for the only release transition; CONCERN 0, INCOMPATIBLE 0, UNRESOLVED 0. The known SupervisorManagerTest failure was confirmed as a base/merge-ref issue and is fixed by remote master commit 33f7f778df. Fresh required checks are queued for the exact head above. No approval or merge was attempted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
