FrankChen021 commented on code in PR #20296:
URL: https://github.com/apache/druid/pull/20296#discussion_r3957838739
##########
pom.xml:
##########
@@ -706,7 +706,7 @@
<dependency>
<groupId>com.github.luben</groupId>
<artifactId>zstd-jni</artifactId>
- <version>1.5.7-11</version>
+ <version>1.5.7-15</version>
Review Comment:
[P2] Upgrading past -12 drops legacy Zstandard decoding
`zstd-jni` documents 1.5.7-12 as the last release that supports the legacy
0.4–0.7 formats; 1.5.7-15 removes them (see
https://github.com/luben/zstd-jni#status-and-availability). Druid exposes
`.zst` as a supported batch-ingestion format, and
`processing/src/main/java/org/apache/druid/utils/CompressionUtils.java:808-809`
constructs `ZstdCompressorInputStream` from this same dependency, so existing
legacy `.zst` inputs that worked with 1.5.7-11 will now fail during ingestion.
Please retain a legacy-capable version (if Parquet works with it) or explicitly
handle, document, and test this compatibility break before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]