gianm commented on code in PR #20245:
URL: https://github.com/apache/druid/pull/20245#discussion_r3962083656
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/StrategicSegmentAssigner.java:
##########
@@ -593,8 +594,7 @@ private void cancelLoadsOnServers(
break;
}
// Try LOAD then REPLICATE; the queued action depends on whether this
was a primary or a replica.
Review Comment:
I think this comment is backwards now.
##########
server/src/main/java/org/apache/druid/server/coordinator/ServerHolder.java:
##########
Review Comment:
Is this line still true? Seems like no? Similar question for the javadoc on
`SegmentAction.REPLICATE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
