FrankChen021 commented on code in PR #20183:
URL: https://github.com/apache/druid/pull/20183#discussion_r3964261599
##########
services/src/main/java/org/apache/druid/cli/CliHistorical.java:
##########
@@ -92,30 +86,22 @@ protected List<? extends Module> getModules()
{
return ImmutableList.of(
new DruidProcessingModule(),
- new QueryableModule(),
- new QueryRunnerFactoryModule(),
- new SegmentWranglerModule(),
- new JoinableFactoryModule(),
Review Comment:
Not out of the scope. it's a tiny refactoring of how native query related
module are installed. otherwise, for overlord, coordinator, middle manager, we
will repeate these code. Now we only need the `NativeQueryEngineModule`
installed, all dependencies are enclosed in this new module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
