gianm commented on code in PR #19976:
URL: https://github.com/apache/druid/pull/19976#discussion_r3964791811
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/CalcitePlanner.java:
##########
@@ -388,20 +403,22 @@ public RelRoot expandView(
final RexBuilder rexBuilder = createRexBuilder();
final RelOptCluster cluster = RelOptCluster.create(planner, rexBuilder);
final SqlToRelConverter.Config config =
- sqlToRelConverterConfig.withTrimUnusedFields(false);
+ sqlToRelConverterConfig.withTrimUnusedFields(false)
+ .withTopDownGeneralDecorrelationEnabled(
+
connectionConfig.topDownGeneralDecorrelationEnabled());
Review Comment:
True, not everything in this file is necessarily reachable. It's meant to be
staying in sync with upstream (it's a modified version of `PlannerImpl`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
