Shekharrajak commented on code in PR #19510:
URL: https://github.com/apache/druid/pull/19510#discussion_r3965184023
##########
extensions-contrib/druid-iceberg-extensions/src/main/java/org/apache/druid/iceberg/input/IcebergArrowInputSourceReader.java:
##########
@@ -113,6 +117,22 @@ public CloseableIterator<InputRow> read(@Nullable final
InputStats inputStats) t
);
}
+ private void validateNoDeleteFiles(final TableScan scan) throws IOException
+ {
+ try (CloseableIterable<FileScanTask> fileTasks = scan.planFiles()) {
+ for (FileScanTask fileTask : fileTasks) {
+ if (!fileTask.deletes().isEmpty()) {
+ throw DruidException.forPersona(DruidException.Persona.USER)
+ .ofCategory(DruidException.Category.UNSUPPORTED)
+ .build(
+ "Arrow reader does not support Iceberg
snapshots with delete files. "
Review Comment:
We can create a ticket to track "Add delete-file support for Iceberg Arrow
reader"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
