jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267163198
########## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java ########## @@ -70,9 +93,14 @@ public boolean hasNext() @Override public ScanResultValue next() { - ScanResultValue batch = yielder.get(); - if (ScanQuery.RESULT_FORMAT_COMPACTED_LIST.equals(resultFormat) || - ScanQuery.RESULT_FORMAT_LIST.equals(resultFormat)) { + if (ScanQuery.ResultFormat.RESULT_FORMAT_VALUE_VECTOR.equals(resultFormat)) { + throw new UOE(ScanQuery.ResultFormat.RESULT_FORMAT_VALUE_VECTOR + " is not supported yet"); + } + + // We want to perform batching if we are not time-ordering or are at the outer level if we are re time-ordering + if (query.getOrder() == ScanQuery.Order.NONE || + !query.getContextBoolean(ScanQuery.CTX_KEY_OUTERMOST, true)) { Review comment: The `!query.getContextBoolean(ScanQuery.CTX_KEY_OUTERMOST, true)` needs to be flipped ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org