gianm commented on PR #20310: URL: https://github.com/apache/druid/pull/20310#issuecomment-5612629037
Benchmarks. Not checked in, but they're doing the two alternatives on various lengths of strings. ``` Benchmark (length) Mode Cnt Score Error Units Utf8CharsetBenchmark.fromUtf8_charsetName 8 avgt 10 9.017 ± 0.040 ns/op Utf8CharsetBenchmark.fromUtf8_charsetName 64 avgt 10 12.426 ± 0.160 ns/op Utf8CharsetBenchmark.fromUtf8_charsetName 1024 avgt 10 43.674 ± 0.298 ns/op Utf8CharsetBenchmark.fromUtf8_charsetObject 8 avgt 10 6.724 ± 0.079 ns/op Utf8CharsetBenchmark.fromUtf8_charsetObject 64 avgt 10 10.231 ± 0.136 ns/op Utf8CharsetBenchmark.fromUtf8_charsetObject 1024 avgt 10 41.794 ± 0.448 ns/op Utf8CharsetBenchmark.toUtf8_charsetName 8 avgt 10 10.255 ± 1.114 ns/op Utf8CharsetBenchmark.toUtf8_charsetName 64 avgt 10 11.069 ± 0.279 ns/op Utf8CharsetBenchmark.toUtf8_charsetName 1024 avgt 10 42.732 ± 0.385 ns/op Utf8CharsetBenchmark.toUtf8_charsetObject 8 avgt 10 3.812 ± 0.063 ns/op Utf8CharsetBenchmark.toUtf8_charsetObject 64 avgt 10 7.024 ± 0.045 ns/op Utf8CharsetBenchmark.toUtf8_charsetObject 1024 avgt 10 39.115 ± 0.431 ns/op ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
