FrankChen021 commented on PR #20316: URL: https://github.com/apache/druid/pull/20316#issuecomment-5628307969
The `unit tests (25, C*)` failure on this PR is unrelated to the change here (this PR only touches `KubernetesTaskRunnerTest`, which is not in the C* shard). The failing test is [`CompactionTaskTest.testCompaction`](https://github.com/apache/druid/actions/runs/34495913311/job/102934192930): ``` CompactionTaskTest.testCompaction -> CompactionTestBase.verifySegmentsCount:102 Segment count mismatch in sys.segments table ==> expected: <2> but was: <4> ``` This is the flake tracked in #20312 (item 7) and fixed by #20320: `verifySegmentsCount` waits for a single `segment/metadataCache/sync/time` event and then asserts the `sys.segments` count once, so a sync that was already in flight can still report the pre-compaction state (here the 4 original segments). #20320 keeps the Overlord assertion and polls the Broker-side count instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
